Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-05 22:05:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bugzilla Bug 334533: in getPQseed we always set the most significant bit of

Browse Source 
SEED to 1 to make NIST CMVP's PQG parameter validation tool happy. In
PQG_ParamGenSeedLen we require the length of SEED be at least 20 bytes.
r=nelson.
This commit is contained in:
wtchang%redhat.com 2006-04-21 17:48:30 +00:00
parent 8c0eca9199
commit 6f1bd4dc40
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
security/nss/lib/freebl/pqg.c
View File

@ -37,7 +37,7 @@
/*
* PQG parameter generation/verification. Based on FIPS 186-1.
*
* $Id: pqg.c,v 1.12 2006/04/20 21:55:24 wtchang%redhat.com Exp $
* $Id: pqg.c,v 1.13 2006/04/21 17:48:30 wtchang%redhat.com Exp $
*/
#include "prerr.h"
@ -78,6 +78,8 @@ static const unsigned char fips_186_1_a5_pqseed[] = {
static SECStatus
getPQseed(SECItem *seed, PRArenaPool* arena)
{
SECStatus rv;
if (!seed->data) {
seed->data = (unsigned char*)PORT_ArenaZAlloc(arena, seed->len);
}
@ -89,7 +91,15 @@ getPQseed(SECItem *seed, PRArenaPool* arena)
memcpy(seed->data, fips_186_1_a5_pqseed, seed->len);
return SECSuccess;
#else
return RNG_GenerateGlobalRandomBytes(seed->data, seed->len);
rv = RNG_GenerateGlobalRandomBytes(seed->data, seed->len);
/*
* NIST CMVP disallows a sequence of 20 bytes with the most
* significant byte equal to 0. Perhaps they interpret
* "a sequence of at least 160 bits" as "a number >= 2^159".
* So we always set the most significant bit to 1. (bug 334533)
*/
seed->data[0] |= 0x80;
return rv;
#endif
}
@ -392,7 +402,7 @@ PQG_ParamGenSeedLen(unsigned int j, unsigned int seedBytes,
mp_err err = MP_OKAY;
SECStatus rv = SECFailure;
int iterations = 0;
if (j > 8 || !pParams || !pVfy) {
if (j > 8 || seedBytes < 20 || !pParams || !pVfy) {
PORT_SetError(SEC_ERROR_INVALID_ARGS);
return SECFailure;
}