Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-29 07:42:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1592121 - Ensure prim instances in culled clusters are reset. r=nical

Browse Source 
This prevents stale indices into the prim visibility scratch
buffer being reused on subsequent frames, which can cause various
unexpected code paths to be hit.

Differential Revision: https://phabricator.services.mozilla.com/D50891

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Glenn Watson 2019-10-29 08:55:16 +00:00
parent 9e65704d9c
commit 6f43be3422
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gfx/wr/webrender/src/prim_store/mod.rs
View File

@ -1931,6 +1931,21 @@ impl PrimitiveStore {
for cluster in &mut prim_list.clusters {
// Get the cluster and see if is visible
if !cluster.flags.contains(ClusterFlags::IS_VISIBLE) {
// Each prim instance must have reset called each frame, to clear
// indices into various scratch buffers. If this doesn't occur,
// the primitive may incorrectly be considered visible, which can
// cause unexpected conditions to occur later during the frame.
// Primitive instances are normally reset in the main loop below,
// but we must also reset them in the rare case that the cluster
// visibility has changed (due to an invalid transform and/or
// backface visibility changing for this cluster).
// TODO(gw): This is difficult to test for in CI - as a follow up,
// we should add a debug flag that validates the prim
// instance is always reset every frame to catch similar
// issues in future.
for prim_instance in &mut cluster.prim_instances {
prim_instance.reset();
}
continue;
}