Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-25 20:01:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1828123: refactor(webidl): align args. naming for GPUComputePassEncoder.dispatchWorkgroups with spec. r=webgpu-reviewers,webidl,peterv,teoxoy

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D185097
This commit is contained in:
Erich Gubler 2023-08-02 13:52:38 +00:00
parent 121ee5fd1e
commit 6f61cf097d
3 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dom/webgpu/ComputePassEncoder.cpp
View File

@ -63,10 +63,12 @@ void ComputePassEncoder::SetPipeline(const ComputePipeline& aPipeline) {
}
}
void ComputePassEncoder::DispatchWorkgroups(uint32_t x, uint32_t y,
uint32_t z) {
void ComputePassEncoder::DispatchWorkgroups(uint32_t workgroupCountX,
uint32_t workgroupCountY,
uint32_t workgroupCountZ) {
if (mValid) {
ffi::wgpu_compute_pass_dispatch_workgroups(mPass, x, y, z);
ffi::wgpu_compute_pass_dispatch_workgroups(
mPass, workgroupCountX, workgroupCountY, workgroupCountZ);
}
}

3
dom/webgpu/ComputePassEncoder.h
View File

@ -58,7 +58,8 @@ class ComputePassEncoder final : public ObjectBase,
// self
void SetPipeline(const ComputePipeline& aPipeline);
void DispatchWorkgroups(uint32_t x, uint32_t y, uint32_t z);
void DispatchWorkgroups(uint32_t workgroupCountX, uint32_t workgroupCountY,
uint32_t workgroupCountZ);
void DispatchWorkgroupsIndirect(const Buffer& aIndirectBuffer,
uint64_t aIndirectOffset);

2
dom/webidl/WebGPU.webidl
View File

@ -916,7 +916,7 @@ interface mixin GPUProgrammablePassEncoder {
Exposed=(Window /* ,DedicatedWorker */), SecureContext]
interface GPUComputePassEncoder {
undefined setPipeline(GPUComputePipeline pipeline);
undefined dispatchWorkgroups(GPUSize32 x, optional GPUSize32 y = 1, optional GPUSize32 z = 1);
undefined dispatchWorkgroups(GPUSize32 workgroupCountX, optional GPUSize32 workgroupCountY = 1, optional GPUSize32 workgroupCountZ = 1);
[Pref="dom.webgpu.indirect-dispatch.enabled"]
undefined dispatchWorkgroupsIndirect(GPUBuffer indirectBuffer, GPUSize64 indirectOffset);