Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-26 14:46:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 944200 followup - Consistently use nscoord_MIN for uninitialized mFloatEdgeIStart/End. r=mats

Browse Source 
This fixes an inconsistency in part 2 (32faa7c639ff), which wrote the
constant for uninitialized in two different ways.

The constructor uses nscoord_MIN for uninitialized, and that's also what
GetFloatEdges tests for, so this should use nscoord_MIN as well.

I believe this is because the review comment in comment 29 was only
partially addressed.

I noticed the difference because it caused broken behavior in a tree
with my patch for bug 1227493, which defines NS_INTRINSIC_WIDTH_UNKNOWN
differently.  Some text was disappearing on github (email and website
on user pages), slack (usernames of private chats in the sidebar), and
twitter (username of user who tweeted a quoted tweet).

MozReview-Commit-ID: Ah9FUPf2dw4

--HG--
extra : rebase_source : 2d947e017647bc6d6029169ef57cddca5aa4f3a9
This commit is contained in:
L. David Baron 2017-05-16 14:31:30 -07:00
parent 8312cf3057
commit 6fa3cf9282
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
layout/generic/nsLineBox.cpp
View File

@ -560,8 +560,8 @@ nsLineBox::ClearFloatEdges()
{
MOZ_ASSERT(IsInline(), "block line can't have float edges");
if (mInlineData) {
mInlineData->mFloatEdgeIStart = NS_INTRINSIC_WIDTH_UNKNOWN;
mInlineData->mFloatEdgeIEnd = NS_INTRINSIC_WIDTH_UNKNOWN;
mInlineData->mFloatEdgeIStart = nscoord_MIN;
mInlineData->mFloatEdgeIEnd = nscoord_MIN;
}
}