Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 09:45:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1534304 - Proper fix for a race condition in an about:debugging test. r=daisuke

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D22996

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Jason Orendorff 2019-03-12 01:53:37 +00:00
parent 26d5920802
commit 705d014bc8
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_telemetry_runtime_updates.js
View File

@ -95,10 +95,6 @@ add_task(async function testUsbRuntimeUpdates() {
info("Remove runtime 1"); info("Remove runtime 1");
await removeUsbRuntime(USB_RUNTIME_1, mocks, document); await removeUsbRuntime(USB_RUNTIME_1, mocks, document);
// Wait a tick for telementry events to settle. (removeUsbRuntime only waits
// for the UI to update.)
await undefined;
checkTelemetryEvents([ checkTelemetryEvents([
{ method: "runtime_disconnected", extras: runtime1ConnectedExtras }, { method: "runtime_disconnected", extras: runtime1ConnectedExtras },
{ method: "runtime_removed", extras: runtime1Extras }, { method: "runtime_removed", extras: runtime1Extras },
@ -130,5 +126,6 @@ async function addUsbRuntime(runtime, mocks, doc) {
async function removeUsbRuntime(runtime, mocks, doc) { async function removeUsbRuntime(runtime, mocks, doc) {
mocks.removeRuntime(runtime.id); mocks.removeRuntime(runtime.id);
mocks.emitUSBUpdate(); mocks.emitUSBUpdate();
await waitUntil(() => !findSidebarItemByText(runtime.shortName, doc)); await waitUntil(() => !findSidebarItemByText(runtime.name, doc) &&
!findSidebarItemByText(runtime.shortName, doc));
} }