Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-16 13:56:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Backed out changeset 474208b76717 (bug 1339537) for failing in cubeb_audiounit.cpp:165. r=backout on a CLOSED TREE

Browse Source
This commit is contained in:
Sebastian Hengst 2017-03-24 21:25:59 +01:00
parent e750fa88bd
commit 71e324817c
4 changed files with 3 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
build/clang-plugin/CustomTypeAnnotation.cpp
View File

@ -15,6 +15,8 @@ CustomTypeAnnotation HeapClass =
CustomTypeAnnotation("moz_heap_class", "heap");
CustomTypeAnnotation NonTemporaryClass =
CustomTypeAnnotation("moz_non_temporary_class", "non-temporary");
CustomTypeAnnotation NonParam =
CustomTypeAnnotation("moz_non_param", "non-param");
void CustomTypeAnnotation::dumpAnnotationReason(BaseCheck &Check,
QualType T,

1
build/clang-plugin/CustomTypeAnnotation.h
View File

@ -67,5 +67,6 @@ extern CustomTypeAnnotation GlobalClass;
extern CustomTypeAnnotation NonHeapClass;
extern CustomTypeAnnotation HeapClass;
extern CustomTypeAnnotation NonTemporaryClass;
extern CustomTypeAnnotation NonParam;
#endif

39
build/clang-plugin/NonParamInsideFunctionDeclChecker.cpp
View File

@ -5,45 +5,6 @@
#include "NonParamInsideFunctionDeclChecker.h"
#include "CustomMatchers.h"
class NonParamAnnotation : public CustomTypeAnnotation
{
public:
NonParamAnnotation() : CustomTypeAnnotation("moz_non_param", "non-param") {};
protected:
// Adding alignas(_) on a struct implicitly marks it as MOZ_NON_PARAM, due to
// MSVC limitations which prevent passing explcitly aligned types by value as
// parameters. This overload of hasFakeAnnotation injects fake MOZ_NON_PARAM
// annotations onto these types.
bool hasFakeAnnotation(const TagDecl *D) const override {
// Check if the decl itself has an AlignedAttr on it.
for (const Attr *A : D->attrs()) {
if (isa<AlignedAttr>(A)) {
D->dump();
return true;
}
}
// Check if any of the decl's fields have an AlignedAttr on them.
if (auto RD = dyn_cast<RecordDecl>(D)) {
for (auto F : RD->fields()) {
for (auto A : F->attrs()) {
if (isa<AlignedAttr>(A)) {
D->dump();
return true;
}
}
}
}
// We don't need to check the types of fields, as the CustomTypeAnnotation
// infrastructure will handle that for us.
return false;
}
};
NonParamAnnotation NonParam;
void NonParamInsideFunctionDeclChecker::registerMatchers(MatchFinder* AstMatcher) {
AstMatcher->addMatcher(
functionDecl(anyOf(allOf(isDefinition(),

10
build/clang-plugin/tests/TestNonParameterChecker.cpp
View File

@ -177,13 +177,3 @@ void testLambda()
(void)[](HasNonParamUnion x) -> void {}; //expected-error {{Type 'HasNonParamUnion' must not be used as parameter}} expected-note {{Please consider passing a const reference instead}}
(void)[](HasNonParamStructUnion x) -> void {}; //expected-error {{Type 'HasNonParamStructUnion' must not be used as parameter}} expected-note {{Please consider passing a const reference instead}}
}
// Check that alignas() implies the MOZ_NON_PARAM attribute.
struct alignas(8) AlignasStruct { char a; };
void takesAlignasStruct(AlignasStruct x) { } // expected-error {{Type 'AlignasStruct' must not be used as parameter}} expected-note {{Please consider passing a const reference instead}}
void takesAlignasStructByRef(const AlignasStruct& x) { }
struct AlignasMember { alignas(8) char a; };
void takesAlignasMember(AlignasMember x) { } // expected-error {{Type 'AlignasMember' must not be used as parameter}} expected-note {{Please consider passing a const reference instead}}
void takesAlignasMemberByRef(const AlignasMember& x) { }