Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-04 11:26:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Oops! canconfirm bit wasn't actually working.

Browse Source
This commit is contained in:
terry%mozilla.org 2000-03-07 21:29:19 +00:00
parent 8640325859
commit 722e3ce72f
1 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
webtools/bugzilla/process_bug.cgi
View File

@ -146,13 +146,8 @@ sub CheckCanChangeField {
"WHERE bug_id = $bugid");
($reporterid, $ownerid, $qacontactid) = (FetchSQLData());
}
if ($reporterid eq $whoid || $ownerid eq $whoid || $qacontactid eq $whoid) {
if ($f ne "bug_status") {
return 1;
}
if ($newvalue eq $::unconfirmedstate || !IsOpenedState($newvalue)) {
return 1;
}
if ($f eq "bug_status" && $newvalue ne $::unconfirmedstate &&
IsOpenedState($newvalue)) {
# Hmm. They are trying to set this bug to some opened state
# that isn't the UNCONFIRMED state. Are they in the right
@ -165,16 +160,14 @@ sub CheckCanChangeField {
if ($UserInCanConfirmGroupSet) {
return 1;
}
my $fieldid = GetFieldID("bug_status");
SendSQL("SELECT newvalue FROM bugs_activity " .
"WHERE fieldid = $fieldid " .
" AND oldvalue = '$::unconfirmedstate'");
while (MoreSQLData()) {
my $n = FetchOneColumn();
if (IsOpenedState($n) && $n ne $::unconfirmedstate) {
return 1;
}
SendSQL("SELECT everconfirmed FROM bugs WHERE bug_id = $bugid");
my $everconfirmed = FetchOneColumn();
if ($everconfirmed) {
return 1;
}
} elsif ($reporterid eq $whoid || $ownerid eq $whoid ||
$qacontactid eq $whoid) {
return 1;
}
SendSQL("UNLOCK TABLES");
$oldvalue = value_quote($oldvalue);