Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-01-27 07:34:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 838349 - Fix bogus use of assertions in Places

Browse Source 
r=trivial
This commit is contained in:
Marco Bonardo 2013-02-06 02:37:07 +01:00
parent 7101e01d5d
commit 7235347b03
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
toolkit/components/places/AsyncFaviconHelpers.cpp
View File

@ -883,7 +883,7 @@ AsyncGetFaviconDataForPage::Run()
rv = FetchIconInfo(mDB, iconData);
if (NS_FAILED(rv)) {
iconData.spec.Truncate();
MOZ_NOT_REACHED("Fetching favicon information failed unexpectedly.");
MOZ_ASSERT(false, "Fetching favicon information failed unexpectedly.");
}
}

2
toolkit/components/places/Database.cpp
View File

@ -166,7 +166,7 @@ SetJournalMode(nsCOMPtr<mozIStorageConnection>& aDBConn,
nsAutoCString journalMode;
switch (aJournalMode) {
default:
MOZ_ASSERT("Trying to set an unknown journal mode.");
MOZ_ASSERT(false, "Trying to set an unknown journal mode.");
// Fall through to the default DELETE journal.
case JOURNAL_DELETE:
journalMode.AssignLiteral("delete");

2
toolkit/components/places/History.cpp
View File

@ -199,7 +199,7 @@ class PlaceHashKey : public nsCStringHashKey
PlaceHashKey(const PlaceHashKey& aOther)
: nsCStringHashKey(&aOther.GetKey())
{
MOZ_ASSERT("Do not call me!");
MOZ_ASSERT(false, "Do not call me!");
}
// Visit count for this place.

2
toolkit/components/places/nsAnnotationService.cpp
View File

@ -1288,7 +1288,7 @@ nsAnnotationService::GetAnnotationsWithName(const nsACString& aName,
break;
}
default:
MOZ_ASSERT("Unsupported annotation type");
MOZ_ASSERT(false, "Unsupported annotation type");
// Move to the next result.
continue;
}