Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 02:14:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1159304 - silence Coverity warning about implicit conversion issues in ReadAheadLib; r=erahm

Browse Source
This commit is contained in:
Nathan Froyd 2015-04-28 12:10:37 -04:00
parent 265eedb594
commit 73b20a0500
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
xpcom/glue/FileUtils.cpp
View File

@ -394,7 +394,11 @@ mozilla::ReadAheadLib(mozilla::pathstr_t aFilePath)
if ((read(fd, elf.buf, bufsize) <= 0) ||
(memcmp(elf.buf, ELFMAG, 4)) ||
(elf.ehdr.e_ident[EI_CLASS] != ELFCLASS) ||
(elf.ehdr.e_phoff + elf.ehdr.e_phentsize * elf.ehdr.e_phnum >= bufsize)) {
// Upcast e_phentsize so the multiplication is done in the same precision
// as the subsequent addition, to satisfy static analyzers and avoid
// issues with abnormally large program header tables.
(elf.ehdr.e_phoff + (static_cast<Elf_Off>(elf.ehdr.e_phentsize) *
elf.ehdr.e_phnum) >= bufsize)) {
close(fd);
return;
}