From f3e6df7c778b4f0df428c6dfd35fe3ee64f0128b Mon Sep 17 00:00:00 2001 From: Neil Rashbrook Date: Thu, 8 Sep 2011 21:20:44 +0100 Subject: [PATCH] Bug 684726 Add missing content types to nsContentBlocker r=bz --- content/base/public/nsIContentPolicy.idl | 2 ++ extensions/permissions/nsContentBlocker.cpp | 30 ++++++++++++--------- extensions/permissions/nsContentBlocker.h | 5 +--- 3 files changed, 20 insertions(+), 17 deletions(-) diff --git a/content/base/public/nsIContentPolicy.idl b/content/base/public/nsIContentPolicy.idl index 8ef1afcf8ed9..122033f69ec6 100644 --- a/content/base/public/nsIContentPolicy.idl +++ b/content/base/public/nsIContentPolicy.idl @@ -136,6 +136,8 @@ interface nsIContentPolicy : nsISupports */ const unsigned long TYPE_MEDIA = 15; + /* Please update nsContentBlocker when adding new content types. */ + ////////////////////////////////////////////////////////////////////// /** diff --git a/extensions/permissions/nsContentBlocker.cpp b/extensions/permissions/nsContentBlocker.cpp index effef4edcbe8..f0e6999cf9bb 100644 --- a/extensions/permissions/nsContentBlocker.cpp +++ b/extensions/permissions/nsContentBlocker.cpp @@ -53,20 +53,24 @@ #define BEHAVIOR_NOFOREIGN 3 // From nsIContentPolicy -static const char *kTypeString[NUMBER_OF_TYPES] = {"other", - "script", - "image", - "stylesheet", - "object", - "document", - "subdocument", - "refresh", - "xbl", - "ping", - "xmlhttprequest", - "objectsubrequest", - "dtd"}; +static const char *kTypeString[] = {"other", + "script", + "image", + "stylesheet", + "object", + "document", + "subdocument", + "refresh", + "xbl", + "ping", + "xmlhttprequest", + "objectsubrequest", + "dtd", + "font", + "media"}; +#define NUMBER_OF_TYPES NS_ARRAY_LENGTH(kTypeString) +PRUint8 nsContentBlocker::mBehaviorPref[NUMBER_OF_TYPES]; NS_IMPL_ISUPPORTS3(nsContentBlocker, nsIContentPolicy, diff --git a/extensions/permissions/nsContentBlocker.h b/extensions/permissions/nsContentBlocker.h index d48eeb5dad54..baaf27f2f543 100644 --- a/extensions/permissions/nsContentBlocker.h +++ b/extensions/permissions/nsContentBlocker.h @@ -46,9 +46,6 @@ class nsIPrefBranch; //////////////////////////////////////////////////////////////////////////////// -// number of permission types in nsIContentPolicy -#define NUMBER_OF_TYPES 13 - class nsContentBlocker : public nsIContentPolicy, public nsIObserver, public nsSupportsWeakReference @@ -75,7 +72,7 @@ private: nsCOMPtr mPermissionManager; nsCOMPtr mPrefBranchInternal; - PRUint8 mBehaviorPref[NUMBER_OF_TYPES]; + static PRUint8 mBehaviorPref[]; }; #define NS_CONTENTBLOCKER_CID \