Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-29 21:25:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

coalesce meteor starts/stops that happen within a 1/2 second of each other - speeds up mail operations

Browse Source 
r=mscott
This commit is contained in:
alecf%netscape.com 2000-01-24 01:54:05 +00:00
parent e20d01d83b
commit 748f272395
2 changed files with 127 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

134
mailnews/base/src/nsMsgStatusFeedback.cpp
View File

@ -30,15 +30,18 @@
#include "nsIDOMXULDocument.h"
#include "nsIObserverService.h"
#define MSGFEEDBACK_TIMER_INTERVAL 500
nsMsgStatusFeedback::nsMsgStatusFeedback()
nsMsgStatusFeedback::nsMsgStatusFeedback() :
mWebShell(nsnull),
mWebShellWindow(nsnull),
m_meteorsSpinning(PR_FALSE),
m_lastPercent(0),
mQueuedMeteorStarts(0),
mQueuedMeteorStops(0)
{
NS_INIT_REFCNT();
m_meteorsSpinning = PR_FALSE;
m_lastPercent = 0;
LL_I2L(m_lastProgressTime, 0);
mWebShell = nsnull;
mWebShellWindow = nsnull;
}
nsMsgStatusFeedback::~nsMsgStatusFeedback()
@ -49,7 +52,10 @@ nsMsgStatusFeedback::~nsMsgStatusFeedback()
//
// nsISupports
//
NS_IMPL_ISUPPORTS3(nsMsgStatusFeedback, nsIMsgStatusFeedback, nsIDocumentLoaderObserver, nsIObserver)
NS_IMPL_ISUPPORTS3(nsMsgStatusFeedback,
nsIMsgStatusFeedback,
nsIDocumentLoaderObserver,
nsIObserver)
// nsIDocumentLoaderObserver
@ -83,11 +89,10 @@ nsMsgStatusFeedback::OnStartDocumentLoad(nsIDocumentLoader* aLoader, nsIURI* aUR
{
// Kick start the throbber
if (!m_meteorsSpinning)
setAttribute( rootWebshell, "Messenger:Throbber", "busy", "true" );
StartMeteors();
else // because of a bug, we're not stopping the meteors, so lets just stop them here.
setAttribute( rootWebshell, "Messenger:Throbber", "busy", "false" );
StopMeteors();
setAttribute( rootWebshell, "Messenger:Status", "value", "Loading Document..." );
m_meteorsSpinning = PR_TRUE;
// Enable the Stop buton
setAttribute( rootWebshell, "canStop", "disabled", "" );
@ -123,9 +128,8 @@ nsMsgStatusFeedback::OnEndDocumentLoad(nsIDocumentLoader* aLoader, nsIChannel* c
if (rootWebshell)
{
// stop the throbber
setAttribute( rootWebshell, "Messenger:Throbber", "busy", "false" );
StopMeteors();
setAttribute( rootWebshell, "Messenger:Status", "value", "Document: Done" );
m_meteorsSpinning = PR_FALSE;
// Disable the Stop buton
setAttribute( rootWebshell, "canStop", "disabled", "true" );
}
@ -258,26 +262,52 @@ nsMsgStatusFeedback::ShowProgress(PRInt32 percentage)
NS_IMETHODIMP
nsMsgStatusFeedback::StartMeteors()
{
if (!m_meteorsSpinning)
{
// meteors are horribly slow, so turn them off for now
setAttribute( mWebShell, "Messenger:Throbber", "busy", "true" );
m_meteorsSpinning = PR_TRUE;
}
return NS_OK;
nsresult rv;
if (!mStartTimer) {
rv = NS_NewTimer(getter_AddRefs(mStartTimer));
if (NS_FAILED(rv)) return rv;
}
// cancel outstanding starts
if (mQueuedMeteorStarts>0) {
mQueuedMeteorStarts--;
NS_ASSERTION(mQueuedMeteorStarts == 0, "destroying unfired/uncanceled start timer");
mStartTimer->Cancel();
}
rv = mStartTimer->Init(notifyStartMeteors, (void *)this,
MSGFEEDBACK_TIMER_INTERVAL);
if (NS_FAILED(rv)) return rv;
mQueuedMeteorStarts++;
return NS_OK;
}
NS_IMETHODIMP
nsMsgStatusFeedback::StopMeteors()
{
if (m_meteorsSpinning)
{
// meteors are horribly slow, so turn them off for now
setAttribute( mWebShell, "Messenger:Throbber", "busy", "false" );
m_meteorsSpinning = PR_FALSE;
}
return NS_OK;
nsresult rv;
if (!mStopTimer) {
rv = NS_NewTimer(getter_AddRefs(mStopTimer));
if (NS_FAILED(rv)) return rv;
}
// cancel outstanding stops
if (mQueuedMeteorStops>0) {
mQueuedMeteorStops--;
NS_ASSERTION(mQueuedMeteorStops == 0, "destroying unfired/uncanceled stop");
mStopTimer->Cancel();
}
rv = mStopTimer->Init(notifyStopMeteors, (void *)this,
MSGFEEDBACK_TIMER_INTERVAL);
if (NS_FAILED(rv)) return rv;
mQueuedMeteorStops++;
return NS_OK;
}
@ -369,3 +399,57 @@ nsresult nsMsgStatusFeedback::setAttribute( nsIWebShell *shell,
}
//
// timer callbacks that resolve closure
//
void
nsMsgStatusFeedback::notifyStartMeteors(nsITimer *aTimer, void *aClosure)
{
NS_ASSERTION(aClosure, "Start meteors: bad nsIMsgStatusFeedback!\n");
if (!aClosure) return;
((nsMsgStatusFeedback*)aClosure)->NotifyStartMeteors(aTimer);
}
void
nsMsgStatusFeedback::notifyStopMeteors(nsITimer *aTimer, void *aClosure)
{
NS_ASSERTION(aClosure, "Stop meteors: bad nsMsgStatusFeedback!\n");
if (!aClosure) return;
((nsMsgStatusFeedback*)aClosure)->NotifyStopMeteors(aTimer);
}
//
// actual timer callbacks
//
void
nsMsgStatusFeedback::NotifyStartMeteors(nsITimer *aTimer)
{
mQueuedMeteorStarts--;
// meteors already spinning, so noop
if (m_meteorsSpinning) return;
// we'll be stopping them soon, don't bother starting.
if (mQueuedMeteorStops > 0) return;
// actually start the meteors
setAttribute(mWebShell, "Messenger:Throbber", "busy", "true");
m_meteorsSpinning = PR_TRUE;
}
void
nsMsgStatusFeedback::NotifyStopMeteors(nsITimer* aTimer)
{
mQueuedMeteorStops--;
// meteors not spinning
if (!m_meteorsSpinning) return;
// there is at least one more timer firing soon
if (mQueuedMeteorStarts > 0) return;
// actually stop the meteors
setAttribute( mWebShell, "Messenger:Throbber", "busy", "false" );
m_meteorsSpinning = PR_FALSE;
}

21
mailnews/base/src/nsMsgStatusFeedback.h
View File

@ -27,11 +27,14 @@
#include "nsIDOMWindow.h"
#include "nsIWebShell.h"
#include "nsIWebShellWindow.h"
#include "nsIObserver.h"
#include "nsIObserver.h"
#include "nsITimer.h"
#include "nsCOMPtr.h"
#include "nsIMsgStatusFeedback.h"
class nsMsgStatusFeedback : public nsIMsgStatusFeedback, public nsIObserver, public nsIDocumentLoaderObserver
class nsMsgStatusFeedback : public nsIMsgStatusFeedback,
public nsIObserver,
public nsIDocumentLoaderObserver
{
public:
nsMsgStatusFeedback();
@ -50,7 +53,6 @@ public:
NS_IMETHOD OnEndURLLoad(nsIDocumentLoader* loader, nsIChannel* channel, nsresult aStatus);
NS_IMETHOD HandleUnknownContentType(nsIDocumentLoader* loader, nsIChannel* channel, const char *aContentType,const char *aCommand );
nsresult setAttribute( nsIWebShell *shell,
const char *id,
const char *name,
@ -63,8 +65,21 @@ protected:
PRInt32 m_lastPercent;
PRInt64 m_lastProgressTime;
PRBool mQueuedMeteorStarts;
PRBool mQueuedMeteorStops;
nsCOMPtr<nsITimer> mStartTimer;
nsCOMPtr<nsITimer> mStopTimer;
void BeginObserving();
void EndObserving();
// timer callbacks
static void notifyStartMeteors(nsITimer *aTimer, void *aClosure);
static void notifyStopMeteors(nsITimer *aTimer, void *aClosure);
// timer callbacks w/resolved closure
void NotifyStartMeteors(nsITimer *aTimer);
void NotifyStopMeteors(nsITimer *aTimer);
};
#endif // _nsMsgStatusFeedback_h