From 75a3688522c8afdc28e68d6c9fff4f9f6d224ee6 Mon Sep 17 00:00:00 2001 From: Jan Varga Date: Sun, 11 Sep 2022 12:00:17 +0000 Subject: [PATCH] Bug 1786465 - Fix code to silence static-analysis warnings; r=dom-storage-reviewers,jesup Differential Revision: https://phabricator.services.mozilla.com/D156889 --- dom/fs/shared/FileSystemHelpers.h | 6 +++--- dom/fs/test/gtest/FileSystemMocks.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dom/fs/shared/FileSystemHelpers.h b/dom/fs/shared/FileSystemHelpers.h index d692216a2e67..26a820f343ee 100644 --- a/dom/fs/shared/FileSystemHelpers.h +++ b/dom/fs/shared/FileSystemHelpers.h @@ -74,13 +74,13 @@ class Registered { } } - Registered() {} + Registered() = default; Registered(const Registered& aOther) : mObject(aOther.mObject) { mObject->Register(); } - Registered(Registered&& aOther) = default; + Registered(Registered&& aOther) noexcept = default; MOZ_IMPLICIT Registered(RefPtr aObject) : mObject(std::move(aObject)) { if (mObject) { @@ -109,7 +109,7 @@ class Registered { return *this; } - Registered& operator=(Registered&& aRhs) { + Registered& operator=(Registered&& aRhs) noexcept { RefPtr oldObject = std::move(mObject); mObject = std::move(aRhs.mObject); aRhs.mObject = nullptr; diff --git a/dom/fs/test/gtest/FileSystemMocks.h b/dom/fs/test/gtest/FileSystemMocks.h index a27df4e2fa3c..83c19e4c9e02 100644 --- a/dom/fs/test/gtest/FileSystemMocks.h +++ b/dom/fs/test/gtest/FileSystemMocks.h @@ -46,7 +46,7 @@ GTEST_API_ ::testing::AssertionResult CmpHelperSTREQ(const char* s1_expression, namespace mozilla::dom::fs { inline std::ostream& operator<<(std::ostream& aOut, - const FileSystemEntryMetadata aMetadata) { + const FileSystemEntryMetadata& aMetadata) { return aOut; }