Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 03:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Checkin in for John Keiser <jkeiser@iname.com>. Make checkboxes and

Browse Source 
radio buttons not fire onChange on pageload if they are checked by
default.  Bug 112218, r=rods, sr=jst
This commit is contained in:
bzbarsky%mit.edu 2002-01-07 20:37:22 +00:00
parent 40b05ee2d6
commit 76acea94df
4 changed files with 36 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
layout/forms/nsGfxCheckboxControlFrame.cpp
View File

@ -313,7 +313,15 @@ nsGfxCheckboxControlFrame::InitializeControl(nsIPresContext* aPresContext)
if (!primaryPresShell) return;
if (presShell.get() == primaryPresShell.get()) {
nsFormControlHelper::Reset(this, aPresContext);
// Reset the value
// XXX We set the checkbox directly in the frame, because
// content fires onChange :(
PRBool checked = PR_FALSE;
nsresult rv = GetDefaultCheckState(&checked);
if (NS_CONTENT_ATTR_HAS_VALUE == rv) {
SetCheckboxState (aPresContext, checked ? eOn : eOff );
}
}
}

11
layout/forms/nsGfxRadioControlFrame.cpp
View File

@ -347,7 +347,7 @@ PRBool nsGfxRadioControlFrame::GetRadioState()
void nsGfxRadioControlFrame::SetRadioState(nsIPresContext* aPresContext, PRBool aValue)
{
mChecked = aValue;
nsFormControlHelper::ForceDrawFrame(aPresContext, this);
nsFormControlHelper::ForceDrawFrame(aPresContext, this);
}
void
@ -370,7 +370,14 @@ nsGfxRadioControlFrame::InitializeControl(nsIPresContext* aPresContext)
if (!primaryPresShell) return;
if (presShell.get() == primaryPresShell.get()) {
nsFormControlHelper::Reset(this, aPresContext);
// set the widget to the initial state
// XXX We can't use reset because radio buttons fire onChange
// from content (much to our dismay)
PRBool checked = PR_FALSE;
nsresult rv = GetDefaultCheckState(&checked);
if (NS_CONTENT_ATTR_HAS_VALUE == rv) {
SetRadioState(aPresContext, checked);
}
}
}

10
layout/html/forms/src/nsGfxCheckboxControlFrame.cpp
View File

@ -313,7 +313,15 @@ nsGfxCheckboxControlFrame::InitializeControl(nsIPresContext* aPresContext)
if (!primaryPresShell) return;
if (presShell.get() == primaryPresShell.get()) {
nsFormControlHelper::Reset(this, aPresContext);
// Reset the value
// XXX We set the checkbox directly in the frame, because
// content fires onChange :(
PRBool checked = PR_FALSE;
nsresult rv = GetDefaultCheckState(&checked);
if (NS_CONTENT_ATTR_HAS_VALUE == rv) {
SetCheckboxState (aPresContext, checked ? eOn : eOff );
}
}
}

11
layout/html/forms/src/nsGfxRadioControlFrame.cpp
View File

@ -347,7 +347,7 @@ PRBool nsGfxRadioControlFrame::GetRadioState()
void nsGfxRadioControlFrame::SetRadioState(nsIPresContext* aPresContext, PRBool aValue)
{
mChecked = aValue;
nsFormControlHelper::ForceDrawFrame(aPresContext, this);
nsFormControlHelper::ForceDrawFrame(aPresContext, this);
}
void
@ -370,7 +370,14 @@ nsGfxRadioControlFrame::InitializeControl(nsIPresContext* aPresContext)
if (!primaryPresShell) return;
if (presShell.get() == primaryPresShell.get()) {
nsFormControlHelper::Reset(this, aPresContext);
// set the widget to the initial state
// XXX We can't use reset because radio buttons fire onChange
// from content (much to our dismay)
PRBool checked = PR_FALSE;
nsresult rv = GetDefaultCheckState(&checked);
if (NS_CONTENT_ATTR_HAS_VALUE == rv) {
SetRadioState(aPresContext, checked);
}
}
}