Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 06:45:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1325303 - A-S Telemetry: track position of highlights for menu interactions r=sebastian

Browse Source 
MozReview-Commit-ID: GXl5asf2rEq

--HG--
extra : rebase_source : 9aa7ee95ed9fe563e31a276b6c0438faa72e9918
This commit is contained in:
Grigory Kruglov 2017-01-26 23:14:08 -08:00
parent e14db054b4
commit 771195ba7b
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mobile/android/base/java/org/mozilla/gecko/home/activitystream/StreamRecyclerAdapter.java
View File

@ -103,7 +103,7 @@ public class StreamRecyclerAdapter extends RecyclerView.Adapter<StreamItem> impl
final int cursorPosition = translatePositionToCursor(position);
highlightsCursor.moveToPosition(cursorPosition);
((HighlightItem) holder).bind(highlightsCursor, tilesWidth, tilesHeight);
((HighlightItem) holder).bind(highlightsCursor, cursorPosition, tilesWidth, tilesHeight);
} else if (type == TopPanel.LAYOUT_ID) {
((TopPanel) holder).bind(topSitesCursor, tiles, tilesWidth, tilesHeight);
}

7
mobile/android/base/java/org/mozilla/gecko/home/activitystream/stream/HighlightItem.java
View File

@ -40,6 +40,7 @@ public class HighlightItem extends StreamItem implements IconCallback {
public static final int LAYOUT_ID = R.layout.activity_stream_card_history_item;
private Highlight highlight;
private int position;
private final FaviconView vIconView;
private final TextView vLabel;
@ -77,6 +78,7 @@ public class HighlightItem extends StreamItem implements IconCallback {
public void onClick(View v) {
ActivityStreamTelemetry.Extras.Builder extras = ActivityStreamTelemetry.Extras.builder()
.set(ActivityStreamTelemetry.Contract.SOURCE_TYPE, ActivityStreamTelemetry.Contract.TYPE_HIGHLIGHTS)
.set(ActivityStreamTelemetry.Contract.ACTION_POSITION, position)
.forHighlightSource(highlight.getSource());
ActivityStreamContextMenu.show(v.getContext(),
@ -98,8 +100,9 @@ public class HighlightItem extends StreamItem implements IconCallback {
ViewUtil.enableTouchRipple(menuButton);
}
public void bind(Cursor cursor, int tilesWidth, int tilesHeight) {
highlight = Highlight.fromCursor(cursor);
public void bind(Cursor cursor, int position, int tilesWidth, int tilesHeight) {
this.highlight = Highlight.fromCursor(cursor);
this.position = position;
vLabel.setText(highlight.getTitle());
vTimeSince.setText(highlight.getRelativeTimeSpan());