From 77294951e7e843280d1e13f6d3df89511780d84f Mon Sep 17 00:00:00 2001 From: Christian Holler Date: Mon, 24 Feb 2020 17:36:00 +0000 Subject: [PATCH] Bug 1614605 - Add permanent deadlock suppressions for single thread. r=keeler Differential Revision: https://phabricator.services.mozilla.com/D63757 --HG-- extra : moz-landing-system : lando --- mozglue/build/TsanOptions.cpp | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/mozglue/build/TsanOptions.cpp b/mozglue/build/TsanOptions.cpp index 3b75196d9b99..76007c0d4a7f 100644 --- a/mozglue/build/TsanOptions.cpp +++ b/mozglue/build/TsanOptions.cpp @@ -127,6 +127,19 @@ extern "C" const char* __tsan_default_suppressions() { "race:nsHttpChannel::OnCacheEntryCheck\n" "race:~AutoCacheWaitFlags\n" + // Deadlock reports on single-threaded runtime. + // + // This is a known false positive from TSan where it reports + // a potential deadlock even though all mutexes are only + // taken by a single thread. For applications/tasks where we + // are absolutely sure that no second thread will be involved + // we should suppress these issues. + // + // See also https://github.com/google/sanitizers/issues/488 + // Bug 1614605 - permanent + "deadlock:SanctionsTestServer\n" + "deadlock:OCSPStaplingServer\n" + // Bug 1153409 "race:third_party/sqlite3/*\n" "deadlock:third_party/sqlite3/*\n" @@ -292,10 +305,6 @@ extern "C" const char* __tsan_default_suppressions() { "race:GCRuntime::setPerformanceHint\n" "race:GCHeapThreshold::updateAfterGC\n" - // Bug 1614605 - "deadlock:SanctionsTestServer\n" - "deadlock:OCSPStaplingServer\n" - // Bug 1614646 "race:nsCookieService::CountCookiesFromHostInternal\n" "race:nsCookieService::InitDBStates\n"