From 776005a2ece5106055d3e866d48fcefef57921bf Mon Sep 17 00:00:00 2001 From: "Nils Ohlmeier [:drno]" Date: Tue, 22 Aug 2017 14:22:52 -0700 Subject: [PATCH] Bug 1392745: verify mid presence in inactive m-section r=mjf MozReview-Commit-ID: 7XISDzZCirr --HG-- extra : rebase_source : a786be541a31edac05647fe2ee4d0c63c982d3d0 --- media/webrtc/signaling/gtest/jsep_session_unittest.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/media/webrtc/signaling/gtest/jsep_session_unittest.cpp b/media/webrtc/signaling/gtest/jsep_session_unittest.cpp index 1c0e043486c9..086ea28214e9 100644 --- a/media/webrtc/signaling/gtest/jsep_session_unittest.cpp +++ b/media/webrtc/signaling/gtest/jsep_session_unittest.cpp @@ -1003,10 +1003,14 @@ protected: ValidateDisabledMSection(const SdpMediaSection* msection) { ASSERT_EQ(1U, msection->GetFormats().size()); - // Maybe validate that no attributes are present except rtpmap and - // inactive? How? + + auto& attrs = msection->GetAttributeList(); + ASSERT_TRUE(attrs.HasAttribute(SdpAttribute::kMidAttribute)); + ASSERT_TRUE(attrs.HasAttribute(SdpAttribute::kDirectionAttribute)); ASSERT_EQ(SdpDirectionAttribute::kInactive, msection->GetDirectionAttribute().mValue); + // attribute list is missing a length function to check if these are + // all the attributes in it if (msection->GetMediaType() == SdpMediaSection::kAudio) { ASSERT_EQ("0", msection->GetFormats()[0]); const SdpRtpmapAttributeList::Rtpmap* rtpmap(msection->FindRtpmap("0"));