Bug 1635768 - Moved MDNCompatibility library to devtools/shared r=mtigley,daisuke

The MDNCompatibility library will be shared between the upcoming
Compatibility Actor and the Compatibility Panel in the inspector.
This library is necessary for tests in Compatibility Panel and
hence is being moved to the devtools/shared looking at it's
requirements in client as well as the devtools/server/actors

Differential Revision: https://phabricator.services.mozilla.com/D75998

devtools/client/inspector/compatibility/UserSettings.js

@@ -9,7 +9,7 @@ const Services = require("Services");
 loader.lazyRequireGetter(
   this,
   "browsersDataset",
-  "devtools/client/inspector/compatibility/lib/dataset/browsers.json"
+  "devtools/shared/compatibility/dataset/browsers.json"
 );
 
 const TARGET_BROWSER_ID = [

devtools/client/inspector/compatibility/actions/compatibility.js

@@ -7,8 +7,8 @@
 const nodeConstants = require("devtools/shared/dom-node-constants");
 
 loader.lazyGetter(this, "mdnCompatibility", () => {
-  const MDNCompatibility = require("devtools/client/inspector/compatibility/lib/MDNCompatibility");
-  const cssPropertiesCompatData = require("devtools/client/inspector/compatibility/lib/dataset/css-properties.json");
+  const MDNCompatibility = require("devtools/shared/compatibility/MDNCompatibility");
+  const cssPropertiesCompatData = require("devtools/shared/compatibility/dataset/css-properties.json");
   return new MDNCompatibility(cssPropertiesCompatData);
 });
 

devtools/client/inspector/compatibility/moz.build

@@ -7,13 +7,11 @@
 DIRS += [
     'actions',
     'components',
-    'lib',
     'reducers',
     'utils',
 ]
 
 BROWSER_CHROME_MANIFESTS += ['test/browser/browser.ini']
-XPCSHELL_TESTS_MANIFESTS += ['test/xpcshell/xpcshell.ini']
 
 DevToolsModules(
     'CompatibilityView.js',

devtools/client/inspector/compatibility/test/browser/browser_compatibility_css-property_issue.js

@@ -5,7 +5,7 @@
 
 // Test whether the deprecated CSS property is shown as issue correctly or not.
 
-const MDNCompatibility = require("devtools/client/inspector/compatibility/lib/MDNCompatibility");
+const MDNCompatibility = require("devtools/shared/compatibility/MDNCompatibility");
 
 const TEST_URI = `
   <style>

devtools/client/inspector/compatibility/test/node/components/components-compatibility-IssueItem.test.js

@@ -10,7 +10,7 @@
 const { shallow } = require("enzyme");
 const React = require("react");
 
-const MDNCompatibility = require("devtools/client/inspector/compatibility/lib/MDNCompatibility");
+const MDNCompatibility = require("devtools/shared/compatibility/MDNCompatibility");
 const IssueItem = React.createFactory(
   require("devtools/client/inspector/compatibility/components/IssueItem")
 );

devtools/client/inspector/compatibility/test/node/components/components-compatibility-IssueList.test.js

@@ -10,7 +10,7 @@
 const { shallow } = require("enzyme");
 const React = require("react");
 
-const MDNCompatibility = require("devtools/client/inspector/compatibility/lib/MDNCompatibility");
+const MDNCompatibility = require("devtools/shared/compatibility/MDNCompatibility");
 const IssueList = React.createFactory(
   require("devtools/client/inspector/compatibility/components/IssueList")
 );

devtools/shared/compatibility/moz.build

@@ -8,6 +8,8 @@ DIRS += [
     'dataset',
 ]
 
+XPCSHELL_TESTS_MANIFESTS += ['test/xpcshell/xpcshell.ini']
+
 DevToolsModules(
     'MDNCompatibility.js',
 )

devtools/shared/compatibility/test/xpcshell/.eslintrc.js

@@ -2,5 +2,5 @@
 
 module.exports = {
   // Extend from the common devtools xpcshell eslintrc config.
-  extends: "../../../../../.eslintrc.xpcshell.js",
+  extends: "../../../../.eslintrc.xpcshell.js",
 };

devtools/shared/compatibility/test/xpcshell/test_mdn-compatibility.js

@@ -4,8 +4,8 @@
 
 // Test for the MDN compatibility diagnosis module.
 
-const MDNCompatibility = require("devtools/client/inspector/compatibility/lib/MDNCompatibility");
-const cssPropertiesCompatData = require("devtools/client/inspector/compatibility/lib/dataset/css-properties.json");
+const MDNCompatibility = require("devtools/shared/compatibility/MDNCompatibility");
+const cssPropertiesCompatData = require("devtools/shared/compatibility/dataset/css-properties.json");
 
 const mdnCompatibility = new MDNCompatibility(cssPropertiesCompatData);
 

devtools/shared/moz.build

@@ -8,6 +8,7 @@ include('../templates.mozbuild')
 
 DIRS += [
     'acorn',
+    'compatibility',
     'css',
     'discovery',
     'heapsnapshot',