Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-04 07:40:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1637459 - Make nsXULElement::HasMenu flush frames. r=tnikkel

Browse Source 
The UITour code assumes that it will return the up-to-date value, which
doesn't happen with lazy frame construction.

This is used sparingly in the front end code, so it doesn't quite
warrant more optimization.

Differential Revision: https://phabricator.services.mozilla.com/D75710
This commit is contained in:
Emilio Cobos Álvarez 2020-05-18 10:43:23 +00:00
parent 583e647fb1
commit 78e77439c9
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dom/xul/nsXULElement.cpp
View File

@ -429,8 +429,8 @@ int32_t nsXULElement::ScreenY() {
}
bool nsXULElement::HasMenu() {
nsMenuFrame* menu = do_QueryFrame(GetPrimaryFrame());
return menu != nullptr;
nsMenuFrame* menu = do_QueryFrame(GetPrimaryFrame(FlushType::Frames));
return !!menu;
}
void nsXULElement::OpenMenu(bool aOpenFlag) {

2
dom/xul/nsXULElement.h
View File

@ -340,7 +340,7 @@ class nsXULElement : public nsStyledElement {
MOZ_CAN_RUN_SCRIPT int32_t ScreenX();
MOZ_CAN_RUN_SCRIPT int32_t ScreenY();
bool HasMenu();
MOZ_CAN_RUN_SCRIPT bool HasMenu();
MOZ_CAN_RUN_SCRIPT void OpenMenu(bool aOpenFlag);
virtual bool PerformAccesskey(bool aKeyCausesActivation,