Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-26 20:30:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1771294 - Skip drawing backdrop-filters with broken transforms r=gfx-reviewers,lsalzman

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D147454
This commit is contained in:
Glenn Watson 2022-05-26 23:43:26 +00:00
parent 73fb2e3f53
commit 7989c0df4a
3 changed files with 37 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gfx/tests/crashtests/1771294.html Normal file
View File

@ -0,0 +1,16 @@
<!DOCTYPE html>
<html>
<head>
<style>
* {
backdrop-filter: invert(86%);
display: table-cell;
zoom: 721146529;
padding-top: 7rem;
transform: matrix3d(0, 16, 2147483648, -49, -128, 140, 207.9298442167209, 512.763543618518, 172.4361353002723, 179, -81, 58.01970174841815, 1.7384436475415694, 243, 214, 3) ! important;
inline-size: 7420vw;
margin: 20%;
}
</style>
</head>
</html>

1
gfx/tests/crashtests/crashtests.list
View File

@ -214,3 +214,4 @@ load 1758127-1.html
load 1762973-1.html
pref(layout.css.backdrop-filter.enabled,true) load 1765667.html
load 1768096-1.html
pref(layout.css.backdrop-filter.enabled,true) load 1771294.html

32
gfx/wr/webrender/src/batch.rs
View File

@ -3000,15 +3000,23 @@ impl BatchBuilder {
ctx.spatial_tree,
);
let top_left = map_prim_to_backdrop.map_point(prim_rect.top_left()).unwrap();
let top_right = map_prim_to_backdrop.map_point(prim_rect.top_right()).unwrap();
let bottom_left = map_prim_to_backdrop.map_point(prim_rect.bottom_left()).unwrap();
let bottom_right = map_prim_to_backdrop.map_point(prim_rect.bottom_right()).unwrap();
let points = [
map_prim_to_backdrop.map_point(prim_rect.top_left()),
map_prim_to_backdrop.map_point(prim_rect.top_right()),
map_prim_to_backdrop.map_point(prim_rect.bottom_left()),
map_prim_to_backdrop.map_point(prim_rect.bottom_right()),
];
let top_left = calculate_screen_uv(top_left * pic_info.device_pixel_scale, backdrop_rect);
let top_right = calculate_screen_uv(top_right * pic_info.device_pixel_scale, backdrop_rect);
let bottom_left = calculate_screen_uv(bottom_left * pic_info.device_pixel_scale, backdrop_rect);
let bottom_right = calculate_screen_uv(bottom_right * pic_info.device_pixel_scale, backdrop_rect);
if points.iter().any(|p| p.is_none()) {
return;
}
let uvs = [
calculate_screen_uv(points[0].unwrap() * pic_info.device_pixel_scale, backdrop_rect),
calculate_screen_uv(points[1].unwrap() * pic_info.device_pixel_scale, backdrop_rect),
calculate_screen_uv(points[2].unwrap() * pic_info.device_pixel_scale, backdrop_rect),
calculate_screen_uv(points[3].unwrap() * pic_info.device_pixel_scale, backdrop_rect),
];
// TODO (gw): This is a hack that provides the GPU cache blocks for an
// ImageSource. We should update the GPU cache interfaces to
@ -3021,10 +3029,10 @@ impl BatchBuilder {
target_rect.max.y as f32,
]),
GpuBlockData::from([0.0; 4]),
GpuBlockData::from(top_left),
GpuBlockData::from(top_right),
GpuBlockData::from(bottom_left),
GpuBlockData::from(bottom_right),
GpuBlockData::from(uvs[0]),
GpuBlockData::from(uvs[1]),
GpuBlockData::from(uvs[2]),
GpuBlockData::from(uvs[3]),
];
let uv_rect_handle = gpu_cache.push_per_frame_blocks(gpu_blocks);