Bug 1598055 - remove valgrind from ubuntu1804 dockerfile and prevent scheduling of mochitest-valgrind r=jmaher

Changes:

Remove the unnecessary setup phase of `valgrind` on the docker image, given that we are not scheduling `mochitest-valgrind` [anywhere](https://searchfox.org/mozilla-central/source/taskcluster/ci/test/mochitest.yml#300) in the CI system.

Also, clean up `test-sets.yml` by renaming the `linux-common-tests` to `linux1604-legacy-tests` to better reflect that the set holds tests that haven't been migrated over to linux1804 yet.

Differential Revision: https://phabricator.services.mozilla.com/D65832

--HG--
extra : moz-landing-system : lando

taskcluster/ci/test/test-platforms.yml

@@ -31,7 +31,6 @@ linux1804-64/opt:
         - desktop-screenshot-capture
         - linux1804-tests
         - mochitest-headless
-        - mochitest-valgrind
         - web-platform-tests-1804
 
 linux1804-64/debug:
@@ -48,7 +47,6 @@ linux1804-64-shippable/opt:
         - linux1804-tests
         - marionette-headless
         - mochitest-headless
-        - mochitest-valgrind
         - web-platform-tests-1804
         - web-platform-tests-wdspec-headless
 
@@ -57,7 +55,6 @@ linux1804-64-devedition/opt:
     test-sets:
         - desktop-screenshot-capture
         - linux1804-tests
-        - mochitest-valgrind
         - web-platform-tests-1804
 
 linux1804-64-asan/opt:
@@ -102,13 +99,13 @@ linux1804-64-ccov/opt:
 linux64/debug:
     build-platform: linux64/debug
     test-sets:
-        - linux-common-tests
+        - linux1604-legacy-tests
         - web-platform-tests-1604
 
 linux64/opt:
     build-platform: linux64/opt
     test-sets:
-        - linux-common-tests
+        - linux1604-legacy-tests
         - web-platform-tests-1604
         - talos
         - linux-talos-flex
@@ -119,7 +116,7 @@ linux64/opt:
 linux64-shippable/opt:
     build-platform: linux64-shippable/opt
     test-sets:
-        - linux-common-tests
+        - linux1604-legacy-tests
         - web-platform-tests-1604
         - talos
         - linux-talos-flex
@@ -136,14 +133,14 @@ linux64-shippable/opt:
 linux64-devedition/opt:
     build-platform: linux64-devedition/opt
     test-sets:
-        - linux-common-tests
+        - linux1604-legacy-tests
         - web-platform-tests-1604
 
 # TODO: use 'asan' label here, instead of -asan/opt
 linux64-asan/opt:
     build-platform: linux64-asan/opt
     test-sets:
-        - linux-common-tests
+        - linux1604-legacy-tests
         - web-platform-tests-1604
 
 linux64-tsan/opt:
@@ -178,7 +175,7 @@ linux64-qr/debug:
 linux64-ccov/opt:
     build-platform: linux64-ccov/opt
     test-sets:
-        - linux-common-tests
+        - linux1604-legacy-tests
         - web-platform-tests-1604
         - talos
 

taskcluster/ci/test/test-sets.yml

@@ -335,7 +335,7 @@ desktop-screenshot-capture:
 linux32-tests:
     - web-platform-tests
 
-linux-common-tests:
+linux1604-legacy-tests:
     - marionette
 
 linux1804-tests:

taskcluster/docker/recipes/ubuntu1804-test-system-setup.sh

@@ -128,31 +128,6 @@ pip install --upgrade pip==19.2.3
 hash -r
 pip install virtualenv==15.2.0
 
-# Install Valgrind (trunk, late Jan 2016) and do some crude sanity
-# checks.  It has to go in /usr/local, otherwise it won't work.  Copy
-# the launcher binary to /usr/bin, though, so that direct invokations
-# of /usr/bin/valgrind also work.  Also install libc6-dbg since
-# Valgrind won't work at all without the debug symbols for libc.so and
-# ld.so being available.
-tooltool_fetch <<'EOF'
-[
-{
-    "size": 41331092,
-    "visibility": "public",
-    "digest": "a89393c39171b8304fc262094a650df9a756543ffe9fbec935911e7b86842c4828b9b831698f97612abb0eca95cf7f7b3ff33ea7a9b0313b30c9be413a5efffc",
-    "algorithm": "sha512",
-    "filename": "valgrind-15775-3206-ubuntu1204.tgz"
-}
-]
-EOF
-cp valgrind-15775-3206-ubuntu1204.tgz /tmp
-(cd / && tar xzf /tmp/valgrind-15775-3206-ubuntu1204.tgz)
-rm /tmp/valgrind-15775-3206-ubuntu1204.tgz
-cp /usr/local/bin/valgrind /usr/bin/valgrind
-apt-get install -y libc6-dbg
-valgrind --version
-valgrind date
-
 # Build a list of packages to purge from the image.
 apt_packages=()
 apt_packages+=('*cheese*')