Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-11 01:57:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

If a binding stops being the most-derived binding for a content node before

Browse Source 
we've fired its constructor, remove it from the constructors-to-be-fired list.
Bug 317265, r+sr=bryner
This commit is contained in:
bzbarsky%mit.edu 2005-11-22 15:48:10 +00:00
parent 758367abc3
commit 79ab1864b5
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
content/xbl/src/nsBindingManager.cpp
View File

@ -344,6 +344,17 @@ nsBindingManager::SetBinding(nsIContent* aContent, nsXBLBinding* aBinding)
return NS_ERROR_OUT_OF_MEMORY;
}
// After this point, aBinding will be the most-derived binding for aContent.
// If we already have a binding for aContent in our table, make sure to
// remove it from the attached stack. Otherwise we might end up firing its
// constructor twice (if aBinding inherits from it) or firing its constructor
// after aContent has been deleted (if aBinding is null and the content node
// dies before we process mAttachedStack).
nsXBLBinding* oldBinding = mBindingTable.GetWeak(aContent);
if (oldBinding && mAttachedStack.RemoveElement(oldBinding)) {
NS_RELEASE(oldBinding);
}
PRBool result = PR_TRUE;
if (aBinding) {