Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-01 06:35:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 904081 - Avoid exceeding query var limit in getFaviconsForUrls() (r=margaret)

Browse Source
This commit is contained in:
Lucas Rocha 2013-08-15 17:39:16 +01:00
parent e72d114acd
commit 79c105da2d
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
mobile/android/base/db/LocalBrowserDB.java
View File

@ -22,6 +22,7 @@ import android.content.ContentValues;
import android.database.ContentObserver;
import android.database.Cursor;
import android.database.CursorWrapper;
import android.database.DatabaseUtils;
import android.graphics.Bitmap;
import android.graphics.drawable.BitmapDrawable;
import android.net.Uri;
@ -752,23 +753,23 @@ public class LocalBrowserDB implements BrowserDB.BrowserDBIface {
@Override
public Cursor getFaviconsForUrls(ContentResolver cr, List<String> urls) {
StringBuilder selection = new StringBuilder();
String[] selectionArgs = new String[urls.size()];
selection.append(Favicons.URL + " IN (");
for (int i = 0; i < urls.size(); i++) {
final String url = urls.get(i);
if (i > 0)
selection.append(" OR ");
selection.append(", ");
selection.append(Favicons.URL + " = ?");
selectionArgs[i] = url;
DatabaseUtils.appendEscapedSQLString(selection, url);
}
selection.append(")");
return cr.query(mCombinedUriWithProfile,
new String[] { Combined.URL, Combined.FAVICON },
selection.toString(),
selectionArgs,
null);
null, null);
}
@Override