Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 13:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 529062 - [Mac] Bookmarks menu entries don't update correctly, r=mak

Browse Source
This commit is contained in:
Asaf Romano 2009-12-17 22:28:10 +01:00
parent 4ead986fb8
commit 7a31cb37fa
1 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
browser/components/places/content/menu.xml
View File

@ -624,8 +624,7 @@
<parameter name="aParentPopup"/>
<parameter name="aBefore"/>
<body><![CDATA[
var element = PlacesUIUtils.createMenuItemForNode(aChild);
let element = PlacesUIUtils.createMenuItemForNode(aChild);
if (aBefore)
aParentPopup.insertBefore(element, aBefore);
else {
@ -642,6 +641,28 @@
if (aParentPopup._endMarker != -1)
aParentPopup._endMarker++;
#ifdef XP_MACOSX
// Bug 529062:
// We rely on the menu* bindings, but those aren't never applied
// in native mac menus, for elements which are added to the document
// through appendChild / insertBefore.
if (this.parentNode.parentNode.localName != "menubar")
return;
function applyBinding(elm) {
// getPropertyCSSValue is semi-deprecared, but there's no
// alternative for parsing css_uri values reliably.
let elmBindingURI = window.getComputedStyle(element, "")
.getPropertyCSSValue("-moz-binding");
if (elmBindingURI.primitiveType == CSSPrimitiveValue.CSS_URI)
document.addBinding(elm, elmBindingURI.getStringValue());
}
applyBinding(element);
if (element.localName == "menu")
applyBinding(element.firstChild);
#endif
]]></body>
</method>