Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-07 09:54:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1826060 - Expose FedCM copy to localization r=anti-tracking-reviewers,fluent-reviewers,flod,timhuang

Browse Source 
Address comments from Nick

Differential Revision: https://phabricator.services.mozilla.com/D178443
This commit is contained in:
Benjamin VanderSloot 2023-06-07 12:52:38 +00:00
parent c71c89df36
commit 7a5e41e9ec
5 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
browser/base/content/browser.xhtml
View File

@ -69,6 +69,7 @@
<link rel="localization" href="browser/browserContext.ftl"/>
<link rel="localization" href="browser/browserSets.ftl"/>
<link rel="localization" href="browser/firefoxView.ftl"/>
<link rel="localization" href="browser/identityCredentialNotification.ftl" />
<link rel="localization" href="browser/menubar.ftl"/>
<link rel="localization" href="browser/originControls.ftl"/>
<link rel="localization" href="browser/panelUI.ftl"/>
@ -88,7 +89,6 @@
<link rel="localization" href="toolkit/printing/printUI.ftl"/>
<!-- Untranslated FTL files -->
<link rel="localization" href="preview/firefoxSuggest.ftl" />
<link rel="localization" href="preview/identityCredentialNotification.ftl" />
<link rel="localization" href="preview/interventions.ftl" />
<link rel="localization" href="preview/stripOnShare.ftl" />

8
browser/components/credentialmanager/identityCredentialNotification.ftl → browser/locales/en-US/browser/identityCredentialNotification.ftl
View File

@ -3,12 +3,16 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
## Credential panel
##
## Identity providers are websites you use to log in to another website, for
## example: Google when you Log in with Google.
##
## Variables:
## $host (String): the hostname of the site that is being displayed.
## $provider (String): the hostname of another website you are using to log in to the site being displayed
identity-credential-header-providers = Sign in with a login provider
identity-credential-header-accounts = Sign in with { $provider }
# Identity providers are websites you use to log into another website, for example: Google when you Log in with Google.
identity-credential-urlbar-anchor =
.tooltiptext = Open login panel
identity-credential-cancel-button =
@ -21,4 +25,4 @@ identity-credential-sign-in-button =
.label = Sign In
.accesskey = S
identity-credential-policy-title = Use { $provider } as a login provider
identity-credential-policy-description = Logging in to { $host } with a { $provider } account is subject to { $provider }’s <label data-l10n-name="privacy-url">Privacy Policy</label> and <label data-l10n-name="tos-url">Terms of Service</label>.
identity-credential-policy-description = Logging in to { $host } with a { $provider } account is subject to their <label data-l10n-name="privacy-url">Privacy Policy</label> and <label data-l10n-name="tos-url">Terms of Service</label>.

1
browser/locales/jar.mn
View File

@ -12,7 +12,6 @@
preview/protections.ftl (../components/protections/content/protections.ftl)
preview/interventions.ftl (../components/urlbar/content/interventions.ftl)
preview/firefoxSuggest.ftl (../components/urlbar/content/firefoxSuggest.ftl)
preview/identityCredentialNotification.ftl (../components/credentialmanager/identityCredentialNotification.ftl)
preview/stripOnShare.ftl (../components/urlbar/content/stripOnShare.ftl)
browser (%browser/**/*.ftl)

2
dom/docs/fedcm.rst
View File

@ -19,7 +19,7 @@ The service for managing state associated with IdentityCredentials is ``Identity
The UI panel is spread around a little. The actual DOM elements are in the HTML subtree with root at ``#identity-credential-notification`` in ``browser/base/content/popup-notifications.inc``. But the CSS describing it is spread through ``browser/themes/shared/customizableui/panelUI-shared.css``, ``browser/themes/shared/identity-credential-notification.css``, and ``browser/themes/shared/notification-icons.css``. Generally speaking, search for ``identity-credential`` in those files to find the relevant ids and classes.
Temporary content strings, which will be moved when included in i18n: ``browser/components/credentialmanager/identityCredentialNotification.ftl``, for now. This will eventually be moved to ``browser/locales/en-US/browser/``.
Content strings: ``browser/locales/en-US/browser/identityCredentialNotification.ftl``.
All of this is entered from the ``navigator.credentials`` object, implemented in ``dom/credentialmanagement/CredentialsContainer.{cpp,h}``.

6
toolkit/components/credentialmanagement/IdentityCredentialPromptService.sys.mjs
View File

@ -139,7 +139,7 @@ export class IdentityCredentialPromptService {
// Localize all strings to be used
// Bug 1797154 - Convert localization calls to use the async formatValues.
let localization = new Localization(
["preview/identityCredentialNotification.ftl"],
["browser/identityCredentialNotification.ftl"],
true
);
let headerMessage = localization.formatValueSync(
@ -316,7 +316,7 @@ export class IdentityCredentialPromptService {
// Localize the description
// Bug 1797154 - Convert localization calls to use the async formatValues.
let localization = new Localization(
["preview/identityCredentialNotification.ftl"],
["browser/identityCredentialNotification.ftl"],
true
);
let [accept, cancel] = localization.formatMessagesSync([
@ -460,7 +460,7 @@ export class IdentityCredentialPromptService {
// Localize all strings to be used
// Bug 1797154 - Convert localization calls to use the async formatValues.
let localization = new Localization(
["preview/identityCredentialNotification.ftl"],
["browser/identityCredentialNotification.ftl"],
true
);
let providerURL = new URL(provider.configURL);