mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-28 23:31:56 +00:00
Bug 1285750 - Remove __defineGetter__/__defineSetter__ telemetry. r=Waldo
This commit is contained in:
parent
442eb5511e
commit
7bd3f26521
@ -88,11 +88,6 @@ function Object_toLocaleString() {
|
||||
|
||||
// ES7 draft (2016 March 8) B.2.2.3
|
||||
function ObjectDefineSetter(name, setter) {
|
||||
if (this === null || this === undefined)
|
||||
AddContentTelemetry(TELEMETRY_DEFINE_GETTER_SETTER_THIS_NULL_UNDEFINED, 1);
|
||||
else
|
||||
AddContentTelemetry(TELEMETRY_DEFINE_GETTER_SETTER_THIS_NULL_UNDEFINED, 0);
|
||||
|
||||
// Step 1.
|
||||
var object = ToObject(this);
|
||||
|
||||
@ -119,11 +114,6 @@ function ObjectDefineSetter(name, setter) {
|
||||
|
||||
// ES7 draft (2016 March 8) B.2.2.2
|
||||
function ObjectDefineGetter(name, getter) {
|
||||
if (this === null || this === undefined)
|
||||
AddContentTelemetry(TELEMETRY_DEFINE_GETTER_SETTER_THIS_NULL_UNDEFINED, 1);
|
||||
else
|
||||
AddContentTelemetry(TELEMETRY_DEFINE_GETTER_SETTER_THIS_NULL_UNDEFINED, 0);
|
||||
|
||||
// Step 1.
|
||||
var object = ToObject(this);
|
||||
|
||||
|
@ -90,7 +90,6 @@
|
||||
#define JSITER_SYMBOLS 0x20 /* also include symbol property keys */
|
||||
#define JSITER_SYMBOLSONLY 0x40 /* exclude string property keys */
|
||||
|
||||
#define TELEMETRY_DEFINE_GETTER_SETTER_THIS_NULL_UNDEFINED 25
|
||||
|
||||
#define REGEXP_FLAGS_SLOT 2
|
||||
|
||||
|
@ -134,13 +134,9 @@ enum {
|
||||
JS_TELEMETRY_DEPRECATED_LANGUAGE_EXTENSIONS_IN_CONTENT,
|
||||
JS_TELEMETRY_DEPRECATED_LANGUAGE_EXTENSIONS_IN_ADDONS,
|
||||
JS_TELEMETRY_ADDON_EXCEPTIONS,
|
||||
JS_TELEMETRY_DEFINE_GETTER_SETTER_THIS_NULL_UNDEFINED,
|
||||
JS_TELEMETRY_END
|
||||
};
|
||||
|
||||
static_assert(JS_TELEMETRY_DEFINE_GETTER_SETTER_THIS_NULL_UNDEFINED == 25,
|
||||
"This value needs to be kept in sync with SelfHostingDefines.h");
|
||||
|
||||
typedef void
|
||||
(*JSAccumulateTelemetryDataCallback)(int id, uint32_t sample, const char* key);
|
||||
|
||||
|
@ -3232,10 +3232,6 @@ AccumulateTelemetryCallback(int id, uint32_t sample, const char* key)
|
||||
case JS_TELEMETRY_ADDON_EXCEPTIONS:
|
||||
Telemetry::Accumulate(Telemetry::JS_TELEMETRY_ADDON_EXCEPTIONS, nsDependentCString(key), sample);
|
||||
break;
|
||||
case JS_TELEMETRY_DEFINE_GETTER_SETTER_THIS_NULL_UNDEFINED:
|
||||
MOZ_ASSERT(sample == 0 || sample == 1);
|
||||
Telemetry::Accumulate(Telemetry::JS_DEFINE_GETTER_SETTER_THIS_NULL_UNDEFINED, sample);
|
||||
break;
|
||||
default:
|
||||
MOZ_ASSERT_UNREACHABLE("Unexpected JS_TELEMETRY id");
|
||||
}
|
||||
|
@ -618,14 +618,6 @@
|
||||
"n_values": 10,
|
||||
"description": "Use of SpiderMonkey's deprecated language extensions in add-ons: ForEach=0, DestructuringForIn=1 (obsolete), LegacyGenerator=2, ExpressionClosure=3, LetBlock=4 (obsolete), LetExpression=5 (obsolete), NoSuchMethod=6 (obsolete), FlagsArgument=7 (obsolete), RegExpSourceProp=8 (obsolete), RestoredRegExpStatics=9 (obsolete), BlockScopeFunRedecl=10"
|
||||
},
|
||||
"JS_DEFINE_GETTER_SETTER_THIS_NULL_UNDEFINED": {
|
||||
"alert_emails": ["jdemooij@mozilla.com"],
|
||||
"bug_numbers": [1249123],
|
||||
"expires_in_version": "55",
|
||||
"kind": "boolean",
|
||||
"releaseChannelCollection": "opt-out",
|
||||
"description": "__defineGetter__ or __defineSetter__ invoked with 1 = null/undefined or 0 = everything else as |this| value"
|
||||
},
|
||||
"XUL_CACHE_DISABLED": {
|
||||
"expires_in_version": "default",
|
||||
"kind": "flag",
|
||||
|
Loading…
Reference in New Issue
Block a user