Bug 1533890: Remove obsolete disableCacheIRCalls pref r=mgaudet

Differential Revision: https://phabricator.services.mozilla.com/D33994

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Iain Ireland 2019-06-06 18:04:55 +00:00
parent d8e1a292ea
commit 7c3448ffb3
4 changed files with 0 additions and 27 deletions

View File

@ -4801,10 +4801,6 @@ AttachDecision CallIRGenerator::tryAttachIsSuspendedGenerator() {
}
AttachDecision CallIRGenerator::tryAttachFunCall() {
if (JitOptions.disableCacheIRCalls) {
return AttachDecision::NoAction;
}
if (!thisval_.isObject() || !thisval_.toObject().is<JSFunction>()) {
return AttachDecision::NoAction;
}
@ -4855,10 +4851,6 @@ AttachDecision CallIRGenerator::tryAttachFunCall() {
}
AttachDecision CallIRGenerator::tryAttachFunApply() {
if (JitOptions.disableCacheIRCalls) {
return AttachDecision::NoAction;
}
if (argc_ != 2) {
return AttachDecision::NoAction;
}
@ -5022,10 +5014,6 @@ bool CallIRGenerator::getTemplateObjectForScripted(HandleFunction calleeFunc,
AttachDecision CallIRGenerator::tryAttachCallScripted(
HandleFunction calleeFunc) {
if (JitOptions.disableCacheIRCalls) {
return AttachDecision::NoAction;
}
// Never attach optimized scripted call stubs for JSOP_FUNAPPLY.
// MagicArguments may escape the frame through them.
if (op_ == JSOP_FUNAPPLY) {
@ -5242,9 +5230,6 @@ AttachDecision CallIRGenerator::tryAttachCallNative(HandleFunction calleeFunc) {
if (isSpecialized) {
TRY_ATTACH(tryAttachSpecialCaseCallNative(calleeFunc));
}
if (JitOptions.disableCacheIRCalls) {
return AttachDecision::NoAction;
}
RootedObject templateObj(cx_);
if (isSpecialized && !getTemplateObjectForNative(calleeFunc, &templateObj)) {
@ -5326,10 +5311,6 @@ bool CallIRGenerator::getTemplateObjectForClassHook(
}
AttachDecision CallIRGenerator::tryAttachCallHook(HandleObject calleeObj) {
if (JitOptions.disableCacheIRCalls) {
return AttachDecision::NoAction;
}
if (op_ == JSOP_FUNAPPLY) {
return AttachDecision::NoAction;
}

View File

@ -122,9 +122,6 @@ DefaultJitOptions::DefaultJitOptions() {
// Toggles whether CacheIR stubs are used.
SET_DEFAULT(disableCacheIR, false);
// Toggles whether CacheIR stubs for calls are used
SET_DEFAULT(disableCacheIRCalls, false);
// Toggles whether sincos optimization is globally disabled.
// See bug984018: The MacOS is the only one that has the sincos fast.
#if defined(XP_MACOSX)

View File

@ -57,7 +57,6 @@ struct DefaultJitOptions {
bool disableRecoverIns;
bool disableScalarReplacement;
bool disableCacheIR;
bool disableCacheIRCalls;
bool disableSincos;
bool disableSink;
bool disableOptimizationLevels;

View File

@ -10285,12 +10285,8 @@ static bool SetContextOptions(JSContext* cx, const OptionParser& op) {
if (const char* str = op.getStringOption("cache-ir-stubs")) {
if (strcmp(str, "on") == 0) {
jit::JitOptions.disableCacheIR = false;
jit::JitOptions.disableCacheIRCalls = true;
} else if (strcmp(str, "off") == 0) {
jit::JitOptions.disableCacheIR = true;
} else if (strcmp(str, "call") == 0) {
jit::JitOptions.disableCacheIR = false;
jit::JitOptions.disableCacheIRCalls = false;
} else {
return OptionFailure("cache-ir-stubs", str);
}