Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-28 07:13:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1607634 - Part 2: Add a ParamTraits implementation for NotNull, r=ipc-reviewers,mccr8

Browse Source 
For now, this implementation is based on the implementation of the underlying
type, with extra checking that the value is not null before wrapping and
returning.

We may want to swap things around in the future so that types like RefPtr<T>
are deserialized using NotNull<T*> or similar, so that the unnecessary
serialization overhead of tracking nullness is unnecessary, however that is not
implemented in this patch.

Differential Revision: https://phabricator.services.mozilla.com/D168884
This commit is contained in:
Nika Layzell 2023-03-14 19:31:39 +00:00
parent c821668d34
commit 7c9385cad1
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
ipc/chromium/src/chrome/common/ipc_message_utils.h
View File

@ -914,6 +914,25 @@ struct ParamTraitsMozilla<nsCOMPtr<T>> {
}
};
template <class T>
struct ParamTraitsMozilla<mozilla::NotNull<T>> {
static void Write(MessageWriter* writer, const mozilla::NotNull<T>& p) {
ParamTraits<T>::Write(writer, p.get());
}
static mozilla::Maybe<mozilla::NotNull<T>> Read(MessageReader* reader) {
auto ptr = ReadParam<T>(reader);
if (!ptr) {
return mozilla::Nothing();
}
if (!*ptr) {
reader->FatalError("unexpected null value");
return mozilla::Nothing();
}
return mozilla::Some(mozilla::WrapNotNull(std::move(*ptr)));
}
};
// Finally, ParamTraits itself.
template <class P>