Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 08:15:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1573817: Remove unused parameters in checkDivideByZeroI32; r=lth

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D41964

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Benjamin Bouvier 2019-08-14 18:54:29 +00:00
parent 2d93c5fbc5
commit 7cba4f993a
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
js/src/wasm/WasmBaselineCompile.cpp
View File

@ -4822,7 +4822,7 @@ class BaseCompiler final : public BaseCompilerInterface {
masm.jump(&returnLabel_);
}
void checkDivideByZeroI32(RegI32 rhs, RegI32 srcDest, Label* done) {
void checkDivideByZeroI32(RegI32 rhs) {
Label nonZero;
masm.branchTest32(Assembler::NonZero, rhs, rhs, &nonZero);
trap(Trap::IntegerDivideByZero);
@ -7021,10 +7021,11 @@ void BaseCompiler::emitQuotientI32() {
RegI32 r, rs, reserved;
pop2xI32ForMulDivI32(&r, &rs, &reserved);
Label done;
if (!isConst || c == 0) {
checkDivideByZeroI32(rs, r, &done);
checkDivideByZeroI32(rs);
}
Label done;
if (!isConst || c == -1) {
checkDivideSignedOverflowI32(rs, r, &done, ZeroOnOverflow(false));
}
@ -7051,12 +7052,10 @@ void BaseCompiler::emitQuotientU32() {
RegI32 r, rs, reserved;
pop2xI32ForMulDivI32(&r, &rs, &reserved);
Label done;
if (!isConst || c == 0) {
checkDivideByZeroI32(rs, r, &done);
checkDivideByZeroI32(rs);
}
masm.quotient32(rs, r, IsUnsigned(true));
masm.bind(&done);
maybeFreeI32(reserved);
freeI32(rs);
@ -7088,10 +7087,11 @@ void BaseCompiler::emitRemainderI32() {
RegI32 r, rs, reserved;
pop2xI32ForMulDivI32(&r, &rs, &reserved);
Label done;
if (!isConst || c == 0) {
checkDivideByZeroI32(rs, r, &done);
checkDivideByZeroI32(rs);
}
Label done;
if (!isConst || c == -1) {
checkDivideSignedOverflowI32(rs, r, &done, ZeroOnOverflow(true));
}
@ -7116,12 +7116,10 @@ void BaseCompiler::emitRemainderU32() {
RegI32 r, rs, reserved;
pop2xI32ForMulDivI32(&r, &rs, &reserved);
Label done;
if (!isConst || c == 0) {
checkDivideByZeroI32(rs, r, &done);
checkDivideByZeroI32(rs);
}
masm.remainder32(rs, r, IsUnsigned(true));
masm.bind(&done);
maybeFreeI32(reserved);
freeI32(rs);