Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 06:11:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 302936: Reject the requestee if he cannot access private attachments - Patch by Fr�d�ric Buclin <LpSolit@gmail.com> r=jouni a=justdave

Browse Source
This commit is contained in:
lpsolit%gmail.com 2005-10-18 17:45:48 +00:00
parent 20c9bb65cb
commit 7d02bf7d1b
3 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
webtools/bugzilla/Bugzilla/Flag.pm
View File

@ -228,10 +228,13 @@ sub count {
=over
=item C<validate($cgi, $bug_id)>
=item C<validate($cgi, $bug_id, $attach_id)>
Validates fields containing flag modifications.
If the attachment is new, it has no ID yet and $attach_id is set
to -1 to force its check anyway.
=back
=cut

3
webtools/bugzilla/Bugzilla/FlagType.pm
View File

@ -320,6 +320,9 @@ to extract flag type IDs from form field names by matching columns
whose name looks like "flag_type-nnn", where "nnn" is the ID,
and returning just the ID portion of matching field names.
If the attachment is new, it has no ID yet and $attach_id is set
to -1 to force its check anyway.
=back
=cut

8
webtools/bugzilla/attachment.cgi
View File

@ -937,11 +937,11 @@ sub insert
$vars->{'message'} = 'user_match_multiple';
}
# Flag::validate() should not detect any reference to existing
# flags when creating a new attachment. Setting the third param
# to -1 will force this function to check this point.
# FlagType::validate() and Flag::validate() should not detect
# any reference to existing flags when creating a new attachment.
# Setting the third param to -1 will force this function to check this point.
Bugzilla::Flag::validate($cgi, $bugid, -1);
Bugzilla::FlagType::validate($cgi, $bugid);
Bugzilla::FlagType::validate($cgi, $bugid, -1);
# Escape characters in strings that will be used in SQL statements.
my $sql_filename = SqlQuote($filename);