From 7e5a46ddbc0362d229651a8688ea3e2320ecb35f Mon Sep 17 00:00:00 2001 From: Perry Jiang Date: Thu, 16 Aug 2018 14:20:41 +0000 Subject: [PATCH] Bug 1434913 - Make FetchEvent.clientId non-nullable r=mrbkap Make FetchEvent.clientId non-nullable Differential Revision: https://phabricator.services.mozilla.com/D2789 --HG-- extra : moz-landing-system : lando --- dom/webidl/FetchEvent.webidl | 4 ++-- .../service-workers/service-worker/fetch-event.https.html.ini | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/dom/webidl/FetchEvent.webidl b/dom/webidl/FetchEvent.webidl index 947f00ed4e5a..148433f356b9 100644 --- a/dom/webidl/FetchEvent.webidl +++ b/dom/webidl/FetchEvent.webidl @@ -12,7 +12,7 @@ Exposed=(ServiceWorker)] interface FetchEvent : ExtendableEvent { [SameObject] readonly attribute Request request; - readonly attribute DOMString? clientId; + readonly attribute DOMString clientId; readonly attribute boolean isReload; [Throws] @@ -21,6 +21,6 @@ interface FetchEvent : ExtendableEvent { dictionary FetchEventInit : EventInit { required Request request; - DOMString? clientId = null; + DOMString clientId = ""; boolean isReload = false; }; diff --git a/testing/web-platform/meta/service-workers/service-worker/fetch-event.https.html.ini b/testing/web-platform/meta/service-workers/service-worker/fetch-event.https.html.ini index 977966d537a6..183b1c3e4be2 100644 --- a/testing/web-platform/meta/service-workers/service-worker/fetch-event.https.html.ini +++ b/testing/web-platform/meta/service-workers/service-worker/fetch-event.https.html.ini @@ -2,9 +2,6 @@ [Service Worker responds to fetch event with the correct keepalive value] expected: FAIL - [Service Worker responds to fetch event with an existing client id] - expected: FAIL - [Service Worker responds to fetch event with the correct isReloadNavigation value] expected: FAIL