Bug 1629450 - Permissions manager tests (extensions/permissions/test/unit) failing in Thunderbird since it's running tests with a real profile. r=baku

After bug 1363541 the calls to Services.prefs.setCharPref("permissions.manager.defaultsUrl", ""); must be done early to have any effect. Otherwise the defaults will already be imported and tests do not get the expected starting point.

Differential Revision: https://phabricator.services.mozilla.com/D70675

--HG--
extra : moz-landing-system : lando

extensions/permissions/test/unit/test_permmanager_migrate_10-11.js

@@ -16,9 +16,9 @@ function GetPermissionsFile(profile) {
 }
 
 add_task(async function test() {
-  /* Create and set up the permissions database */
-  let profile = do_get_profile();
+  // Create and set up the permissions database.
   Services.prefs.setCharPref("permissions.manager.defaultsUrl", "");
+  let profile = do_get_profile();
 
   // We need to execute a pm method to be sure that the DB is fully
   // initialized.

extensions/permissions/test/unit/test_permmanager_migrate_4-7.js

@@ -16,9 +16,9 @@ function GetPermissionsFile(profile) {
 }
 
 add_task(async function test() {
-  /* Create and set up the permissions database */
-  let profile = do_get_profile();
+  // Create and set up the permissions database.
   Services.prefs.setCharPref("permissions.manager.defaultsUrl", "");
+  let profile = do_get_profile();
 
   // We need to execute a pm method to be sure that the DB is fully
   // initialized.

extensions/permissions/test/unit/test_permmanager_migrate_4-7_no_history.js

@@ -46,9 +46,9 @@ function GetPermissionsFile(profile) {
  */
 
 add_task(function test() {
-  /* Create and set up the permissions database */
-  let profile = do_get_profile();
+  // Create and set up the permissions database.
   Services.prefs.setCharPref("permissions.manager.defaultsUrl", "");
+  let profile = do_get_profile();
 
   // Make sure that we can't resolve the nsINavHistoryService
   try {

extensions/permissions/test/unit/test_permmanager_migrate_5-7a.js

@@ -16,9 +16,9 @@ function GetPermissionsFile(profile) {
 }
 
 add_task(async function test() {
-  /* Create and set up the permissions database */
-  let profile = do_get_profile();
+  // Create and set up the permissions database.
   Services.prefs.setCharPref("permissions.manager.defaultsUrl", "");
+  let profile = do_get_profile();
 
   // We need to execute a pm method to be sure that the DB is fully
   // initialized.

extensions/permissions/test/unit/test_permmanager_migrate_5-7b.js

@@ -16,9 +16,9 @@ function GetPermissionsFile(profile) {
 }
 
 add_task(function test() {
-  /* Create and set up the permissions database */
-  let profile = do_get_profile();
+  // Create and set up the permissions database.
   Services.prefs.setCharPref("permissions.manager.defaultsUrl", "");
+  let profile = do_get_profile();
 
   var pm = Services.perms;
   Assert.equal(pm.all.length, 0, "No cookies");

extensions/permissions/test/unit/test_permmanager_migrate_6-7a.js

@@ -16,9 +16,9 @@ function GetPermissionsFile(profile) {
 }
 
 add_task(async function test() {
-  /* Create and set up the permissions database */
-  let profile = do_get_profile();
+  // Create and set up the permissions database.
   Services.prefs.setCharPref("permissions.manager.defaultsUrl", "");
+  let profile = do_get_profile();
 
   // We need to execute a pm method to be sure that the DB is fully
   // initialized.

extensions/permissions/test/unit/test_permmanager_migrate_6-7b.js

@@ -16,9 +16,9 @@ function GetPermissionsFile(profile) {
 }
 
 add_task(function test() {
-  /* Create and set up the permissions database */
-  let profile = do_get_profile();
+  // Create and set up the permissions database.
   Services.prefs.setCharPref("permissions.manager.defaultsUrl", "");
+  let profile = do_get_profile();
 
   // We need to execute a pm method to be sure that the DB is fully
   // initialized.

extensions/permissions/test/unit/test_permmanager_migrate_7-8.js

@@ -16,9 +16,9 @@ function GetPermissionsFile(profile) {
 }
 
 add_task(async function test() {
-  /* Create and set up the permissions database */
-  let profile = do_get_profile();
+  // Create and set up the permissions database.
   Services.prefs.setCharPref("permissions.manager.defaultsUrl", "");
+  let profile = do_get_profile();
 
   // We need to execute a pm method to be sure that the DB is fully
   // initialized.

extensions/permissions/test/unit/test_permmanager_migrate_9-10.js

@@ -16,9 +16,9 @@ function GetPermissionsFile(profile) {
 }
 
 add_task(async function test() {
-  /* Create and set up the permissions database */
-  let profile = do_get_profile();
+  // Create and set up the permissions database.
   Services.prefs.setCharPref("permissions.manager.defaultsUrl", "");
+  let profile = do_get_profile();
 
   // We need to execute a pm method to be sure that the DB is fully
   // initialized.

extensions/permissions/test/unit/test_permmanager_removeall.js

@@ -2,6 +2,7 @@
    http://creativecommons.org/publicdomain/zero/1.0/ */
 
 add_task(async function test() {
+  Services.prefs.setCharPref("permissions.manager.defaultsUrl", "");
   // setup a profile directory
   var dir = do_get_profile();