Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-23 10:15:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1397445: Remove expiring FILE_EMBEDDED_SERVICEWORKERS telemetry probe. r=bkelly

Browse Source 
This measured service workers registered in https iframes contained in file:// pages.
This commit is contained in:
David Parks 2017-09-08 11:21:27 -07:00
parent af96b53a25
commit 7e742d04cb
3 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dom/workers/ServiceWorkerManager.cpp
View File

@ -38,7 +38,6 @@
#include "mozilla/Telemetry.h" #include "mozilla/Telemetry.h"
#include "mozilla/dom/BindingUtils.h" #include "mozilla/dom/BindingUtils.h"
#include "mozilla/dom/ContentParent.h" #include "mozilla/dom/ContentParent.h"
#include "mozilla/dom/ContentChild.h"
#include "mozilla/dom/DOMError.h" #include "mozilla/dom/DOMError.h"
#include "mozilla/dom/ErrorEvent.h" #include "mozilla/dom/ErrorEvent.h"
#include "mozilla/dom/Headers.h" #include "mozilla/dom/Headers.h"
@ -955,17 +954,6 @@ ServiceWorkerManager::Register(mozIDOMWindow* aWindow,
AssertIsOnMainThread(); AssertIsOnMainThread();
Telemetry::Accumulate(Telemetry::SERVICE_WORKER_REGISTRATIONS, 1); Telemetry::Accumulate(Telemetry::SERVICE_WORKER_REGISTRATIONS, 1);
ContentChild* contentChild = ContentChild::GetSingleton();
if (contentChild &&
contentChild->GetRemoteType().EqualsLiteral(FILE_REMOTE_TYPE)) {
nsString message(NS_LITERAL_STRING("ServiceWorker registered by document "
"embedded in a file:/// URI. This may "
"result in unexpected behavior."));
ReportToAllClients(cleanedScope, message, EmptyString(),
EmptyString(), 0, 0, nsIScriptError::warningFlag);
Telemetry::Accumulate(Telemetry::FILE_EMBEDDED_SERVICEWORKERS, 1);
}
promise.forget(aPromise); promise.forget(aPromise);
return NS_OK; return NS_OK;
} }

8
toolkit/components/telemetry/Histograms.json
View File

@ -11766,14 +11766,6 @@
"n_buckets": 20, "n_buckets": 20,
"description": "Tracking how long a ServiceWorker stays alive after it is spawned. File bugs in Core::DOM in case of a Telemetry regression." "description": "Tracking how long a ServiceWorker stays alive after it is spawned. File bugs in Core::DOM in case of a Telemetry regression."
}, },
"FILE_EMBEDDED_SERVICEWORKERS": {
"record_in_processes": ["main", "content"],
"alert_emails": ["dparks@mozilla.com"],
"expires_in_version": "58",
"kind": "count",
"bug_numbers": [1312788],
"description": "Count ServiceWorkers that are embedded in pages loading with the file:/// protocol."
},
"GRAPHICS_SANITY_TEST": { "GRAPHICS_SANITY_TEST": {
"record_in_processes": ["main", "content"], "record_in_processes": ["main", "content"],
"expires_in_version": "never", "expires_in_version": "never",

1
toolkit/components/telemetry/histogram-whitelists.json
View File

@ -1799,7 +1799,6 @@
"FENNEC_SYNC_NUMBER_OF_SYNCS_FAILED_BACKOFF", "FENNEC_SYNC_NUMBER_OF_SYNCS_FAILED_BACKOFF",
"FENNEC_SYNC_NUMBER_OF_SYNCS_STARTED", "FENNEC_SYNC_NUMBER_OF_SYNCS_STARTED",
"FENNEC_WAS_KILLED", "FENNEC_WAS_KILLED",
"FILE_EMBEDDED_SERVICEWORKERS",
"FIPS_ENABLED", "FIPS_ENABLED",
"FXA_CONFIGURED", "FXA_CONFIGURED",
"FX_BROWSER_FULLSCREEN_USED", "FX_BROWSER_FULLSCREEN_USED",