Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-11 20:35:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 149845 - buglist.cgi checks for ORDER validity are wrong

Browse Source 
r=myk x2
This commit is contained in:
bbaetz%student.usyd.edu.au 2002-06-08 03:06:10 +00:00
parent 9fb81cdaf6
commit 7eb23ca2d9
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
webtools/bugzilla/buglist.cgi
View File

@ -1302,11 +1302,13 @@ if ($order) {
# by which to sort the results.
ORDER: for ($order) {
/\./ && do {
my @columnnames = map($columns->{lc($_)}->{'name'}, keys(%$columns));
# A custom list of columns. Make sure each column is valid.
foreach my $fragment (split(/[,\s]+/, $order)) {
next if $fragment =~ /^asc|desc$/i;
my @columnnames = map($columns->{lc($_)}->{'name'}, keys(%$columns));
if (!grep($_ eq $fragment, @columnnames)) {
foreach my $fragment (split(/,/, $order)) {
$fragment = trim($fragment);
# Accept an order fragment matching a column name, with
# asc|desc optionally following (to specify the direction)
if (!grep($fragment =~ /^\Q$_\E(\s+(asc|desc))?$/, @columnnames)) {
my $qfragment = html_quote($fragment);
my $error = "The custom sort order you specified in your "
. "form submission contains an invalid column "