Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 08:15:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1562875 - Listmanager kiffoffUpdate doesn't need to obtain on-disk data. r=gcp

Browse Source 
While listmanager called |kickoffUpdate|, it used to call |GetTables| to
retrieve update information and used the information to distinguish if
a table is a "existing" table or not.

In Bug 1045163, the "existing table" logic was removed, which also means we
don't need to call |GetTabkes| anymore. This patch removes calling
Classifier::TableRequest to reduce unnecessary disk IO during startup.

Differential Revision: https://phabricator.services.mozilla.com/D37037

--HG--
extra : moz-landing-system : lando
This commit is contained in:
dlee 2019-07-11 12:49:14 +00:00
parent 7037a2b100
commit 7f68ef9467
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
toolkit/components/url-classifier/UrlClassifierListManager.jsm
View File

@ -274,7 +274,7 @@ PROT_ListManager.prototype.setUpdateCheckTimer = function(updateUrl, delay) {
/**
* Acts as a nsIUrlClassifierCallback for getTables.
*/
PROT_ListManager.prototype.kickoffUpdate_ = function(onDiskTableData) {
PROT_ListManager.prototype.kickoffUpdate_ = function() {
this.startingUpdate_ = false;
var initialUpdateDelay = 3000;
// Add a fuzz of 0-1 minutes for both v2 and v4 according to Bug 1305478.
@ -359,7 +359,7 @@ PROT_ListManager.prototype.maybeToggleUpdateChecking = function() {
if (!this.startingUpdate_) {
this.startingUpdate_ = true;
// check the current state of tables in the database
this.dbService_.getTables(this.kickoffUpdate_.bind(this));
this.kickoffUpdate_();
}
} else {
log("Stopping managing lists (if currently active)");