Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 06:43:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1886471 - Fix racy TestHangsHang test r=ipc-reviewers,nika

Browse Source 
This is very likely to address the cause of the intermittent failure.

Differential Revision: https://phabricator.services.mozilla.com/D205246
This commit is contained in:
Alex 2024-03-21 14:20:45 +00:00
parent 2099cdafe7
commit 7f8d271a8c
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ipc/ipdl/test/gtest/TestHangs.cpp
View File

@ -25,8 +25,7 @@ enum class HangMode : uint32_t {
/// The synchronous call should time out.
Hang,
/// The synchronous call should time out but the response should still be
/// received
/// (racing with the reply timeout logic).
/// received (racing with the reply timeout logic).
HangButReceive,
/// The synchronous call should time out but the response should still be
/// received because the child indicates that processing should continue after
@ -50,8 +49,10 @@ class TestHangsChild : public PTestHangsChild {
this->hangMode = (HangMode)hangMode;
auto result = SendHang(hangMode, timeout->CloneHandle());
// Only the `Hang` mode should actually fail.
if (this->hangMode == HangMode::Hang) {
// Only the `Hang` mode should actually fail.
// See description in parent.
timeout->Signal();
EXPECT_FALSE(result);
} else {
EXPECT_TRUE(result);
@ -102,6 +103,13 @@ class TestHangsParent : public PTestHangsParent {
// Wait to ensure the child process has called
// ShouldContinueFromReplyTimeout().
timeout->Wait();
if (hangMode == (uint32_t)HangMode::Hang) {
// Wait to ensure the child process has returned from `SendHang()`,
// otherwise the reply message can race with the processing after
// ShouldContinueFromReplyTimeout().
timeout->Wait();
}
}
return IPC_OK();
}