Bug 869234 - No need for barriers on the LIR constant pool. r=bhackett

This commit is contained in:
Terrence Cole 2013-05-08 11:45:22 -07:00
parent a10c1d6314
commit 7f90557cc4
3 changed files with 5 additions and 5 deletions

View File

@ -723,7 +723,7 @@ IonScript::copyBailoutTable(const SnapshotOffset *table)
} }
void void
IonScript::copyConstants(const HeapValue *vp) IonScript::copyConstants(const Value *vp)
{ {
for (size_t i = 0; i < constantEntries_; i++) for (size_t i = 0; i < constantEntries_; i++)
constants()[i].init(vp[i]); constants()[i].init(vp[i]);

View File

@ -448,7 +448,7 @@ struct IonScript
void destroyCaches(); void destroyCaches();
void copySnapshots(const SnapshotWriter *writer); void copySnapshots(const SnapshotWriter *writer);
void copyBailoutTable(const SnapshotOffset *table); void copyBailoutTable(const SnapshotOffset *table);
void copyConstants(const HeapValue *vp); void copyConstants(const Value *vp);
void copySafepointIndices(const SafepointIndex *firstSafepointIndex, MacroAssembler &masm); void copySafepointIndices(const SafepointIndex *firstSafepointIndex, MacroAssembler &masm);
void copyOsiIndices(const OsiIndex *firstOsiIndex, MacroAssembler &masm); void copyOsiIndices(const OsiIndex *firstOsiIndex, MacroAssembler &masm);
void copyRuntimeData(const uint8_t *data); void copyRuntimeData(const uint8_t *data);

View File

@ -1256,7 +1256,7 @@ public:
class LIRGraph class LIRGraph
{ {
Vector<LBlock *, 16, IonAllocPolicy> blocks_; Vector<LBlock *, 16, IonAllocPolicy> blocks_;
Vector<HeapValue, 0, IonAllocPolicy> constantPool_; Vector<Value, 0, IonAllocPolicy> constantPool_;
Vector<LInstruction *, 0, IonAllocPolicy> safepoints_; Vector<LInstruction *, 0, IonAllocPolicy> safepoints_;
Vector<LInstruction *, 0, IonAllocPolicy> nonCallSafepoints_; Vector<LInstruction *, 0, IonAllocPolicy> nonCallSafepoints_;
uint32_t numVirtualRegisters_; uint32_t numVirtualRegisters_;
@ -1327,10 +1327,10 @@ class LIRGraph
size_t numConstants() const { size_t numConstants() const {
return constantPool_.length(); return constantPool_.length();
} }
HeapValue *constantPool() { Value *constantPool() {
return &constantPool_[0]; return &constantPool_[0];
} }
const HeapValue &getConstant(size_t index) const { const Value &getConstant(size_t index) const {
return constantPool_[index]; return constantPool_[index];
} }
void setEntrySnapshot(LSnapshot *snapshot) { void setEntrySnapshot(LSnapshot *snapshot) {