Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-26 04:09:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1359848 - Part 2: Avoid two hashtable lookups when registering a new preference observer; r=froydnj

Browse Source
This commit is contained in:
Ehsan Akhgari 2017-04-28 14:31:27 -04:00
parent 49ea4e277a
commit 7f9af03e0b
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
modules/libpref/nsPrefBranch.cpp
View File

@ -723,13 +723,14 @@ NS_IMETHODIMP nsPrefBranch::AddObserver(const char *aDomain, nsIObserver *aObser
pCallback = new PrefCallback(aDomain, aObserver, this);
}
if (mObservers.Get(pCallback)) {
auto p = mObservers.LookupForAdd(pCallback);
if (p) {
NS_WARNING("Ignoring duplicate observer.");
delete pCallback;
return NS_OK;
}
mObservers.Put(pCallback, pCallback);
mObservers.Insert(p, pCallback);
// We must pass a fully qualified preference name to the callback
// aDomain == nullptr is the only possible failure, and we trapped it with