Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 03:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

150716 patch by bienvenu and darin. r=dougt sr=bienvenu. make compact folders work again. The fix is to clear all the member variables pertaining to the request before calling OnStopRequest

Browse Source
This commit is contained in:
naving%netscape.com 2002-06-14 01:40:54 +00:00
parent 8d1abc7bef
commit 7fd6d65393
1 changed files with 22 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
netwerk/base/src/nsFileTransport.cpp
View File

@ -852,25 +852,24 @@ nsFileTransport::Process(nsIProgressEventSink *progressSink)
NS_ConvertASCIItoUCS2(mStreamName).get());
}
// see http://bugzilla.mozilla.org/show_bug.cgi?id=139556#c64
// for the reason behind this evil reference counting.
nsISupports* doomed = mContext.get();
NS_IF_ADDREF(doomed);
mContext = 0;
if (mListener) {
mListener->OnStopRequest(this, mContext, mStatus);
nsCOMPtr<nsIStreamListener> listener = do_QueryInterface(mListener);
mListener = 0;
listener->OnStopRequest(this, doomed, mStatus);
}
// if we have a context, we have to ensure that it is released on the
// proper thread.
if (mContext) {
if (mEventQ) {
// see http://bugzilla.mozilla.org/show_bug.cgi?id=139556#c64
// for the reason behind this evil reference counting.
nsISupports* doomed = mContext.get();
NS_ADDREF(doomed);
mContext = 0;
if (doomed) {
if (mEventQ)
NS_ProxyRelease(mEventQ, doomed);
}
else {
mContext = nsnull;
}
else
NS_IF_RELEASE(doomed);
}
break;
}
@ -1039,25 +1038,24 @@ nsFileTransport::Process(nsIProgressEventSink *progressSink)
NS_NET_STATUS_WROTE_TO,
NS_ConvertASCIItoUCS2(mStreamName).get());
// see http://bugzilla.mozilla.org/show_bug.cgi?id=139556#c64
// for the reason behind this evil reference counting.
nsISupports* doomed = mContext.get();
NS_ADDREF(doomed);
mContext = 0;
if (mProvider) {
mProvider->OnStopRequest(this, mContext, mStatus);
nsCOMPtr <nsIStreamProvider> provider = do_QueryInterface(mProvider);
mProvider = 0;
provider->OnStopRequest(this, doomed, mStatus);
}
// if we have a context, we have to ensure that it is released on the
// proper thread.
if (mContext) {
if (mEventQ) {
// see http://bugzilla.mozilla.org/show_bug.cgi?id=139556#c64
// for the reason behind this evil reference counting.
nsISupports* doomed = mContext.get();
NS_ADDREF(doomed);
mContext = 0;
if (doomed) {
if (mEventQ)
NS_ProxyRelease(mEventQ, doomed);
}
else {
mContext = nsnull;
}
else
NS_RELEASE(doomed);
}
mXferState = CLOSING;
break;