Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 09:45:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1244916 - JSON Viewer: empty arrays should hide the zero count. r=odvarko

Browse Source
This commit is contained in:
Dalimil Hajek 2016-07-15 07:52:00 -04:00
parent adfcd55bb8
commit 806745713c
4 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
devtools/client/shared/components/reps/array.js
View File

@ -127,7 +127,8 @@ define(function (require, exports, module) {
let items;
if (mode == "tiny") {
items = DOM.span({className: "length"}, object.length);
let isEmpty = object.length === 0;
items = DOM.span({className: "length"}, isEmpty ? "" : object.length);
} else {
let max = (mode == "short") ? 3 : 300;
items = this.arrayIterator(object, max);

4
devtools/client/shared/components/reps/grip-array.js
View File

@ -108,7 +108,9 @@ define(function (require, exports, module) {
let items;
if (mode == "tiny") {
items = span({className: "length"}, this.getLength(object));
let objectLength = this.getLength(object);
let isEmpty = objectLength === 0;
items = span({className: "length"}, isEmpty ? "" : objectLength);
} else {
let max = (mode == "short") ? 3 : 300;
items = this.arrayIterator(object, max);

2
devtools/client/shared/components/test/mochitest/test_reps_array.html
View File

@ -64,7 +64,7 @@ window.onload = Task.async(function* () {
},
{
mode: "tiny",
expectedOutput: `[0]`,
expectedOutput: `[]`,
},
{
mode: "short",

2
devtools/client/shared/components/test/mochitest/test_reps_grip-array.html
View File

@ -57,7 +57,7 @@ window.onload = Task.async(function* () {
},
{
mode: "tiny",
expectedOutput: `[0]`,
expectedOutput: `[]`,
},
{
mode: "short",