Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 13:51:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1797104 - Dump crash report after desktop gtest timeouts; r=jmaher

Browse Source 
Following a gtest timeout, signal the process to generate a minidump, then
dump the crash report to the test log, just like the existing timeout
handling for mochitest, reftest, etc.
This makes no changes for Android; it was already working.

Differential Revision: https://phabricator.services.mozilla.com/D160249
This commit is contained in:
Geoff Brown 2022-10-25 17:41:07 +00:00
parent d0b5d62f69
commit 80e9f2b640
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
testing/gtest/rungtests.py
View File

@ -67,14 +67,20 @@ class GTests(object):
process_output = f
proc = None
def timeout_handler():
mozcrash.kill_and_get_minidump(proc.pid, cwd, utility_path)
proc = mozprocess.ProcessHandler(
[prog, "-unittest", "--gtest_death_test_style=threadsafe"],
cwd=cwd,
env=env,
kill_on_timeout=False,
onTimeout=(timeout_handler,),
processOutputLine=process_output,
)
# TODO: After bug 811320 is fixed, don't let .run() kill the process,
# instead use a timeout in .wait() and then kill to get a stack.
proc.run(
timeout=GTests.TEST_PROC_TIMEOUT,
outputTimeout=GTests.TEST_PROC_NO_OUTPUT_TIMEOUT,
@ -91,6 +97,7 @@ class GTests(object):
log.testFail(
"gtest | timed out after %d seconds", GTests.TEST_PROC_TIMEOUT
)
mozcrash.check_for_crashes(cwd, symbols_path, test_name="gtest")
return False
if mozcrash.check_for_crashes(cwd, symbols_path, test_name="gtest"):
# mozcrash will output the log failure line for us.