Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-29 07:42:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bug 127252 patch partially by mstoltz r=bbaetz/me sr=darin a=asa

Browse Source 
make about:config work again
This commit is contained in:
cbiesinger%web.de 2006-09-15 09:51:43 +00:00
parent 89825d4e4f
commit 8124655759
1 changed files with 22 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
docshell/base/nsAboutRedirector.cpp
View File

@ -51,12 +51,25 @@ static NS_DEFINE_CID(kIOServiceCID, NS_IOSERVICE_CID);
NS_IMPL_ISUPPORTS1(nsAboutRedirector, nsIAboutModule)
struct RedirEntry {
const char* id;
const char* url;
PRBool dropChromePrivs; // if PR_TRUE, the page will not have chrome privileges
};
// if you add something here, make sure you update the total
static const char *kRedirMap[][2] = {
{ "credits", "http://www.mozilla.org/credits/" },
{ "mozilla", "chrome://global/content/mozilla.html" },
{ "plugins", "chrome://global/content/plugins.html" },
{ "config", "chrome://global/content/config.xul" }
/*
Entries with dropChromePrivs == PR_FALSE will run with chrome
privileges. This is potentially dangerous. Please use PR_TRUE
as the third argument to each map item below unless your about:
page really needs chrome privileges. Security review is required
before adding new map entries with dropChromePrivs == PR_FALSE.
*/
static RedirEntry kRedirMap[] = {
{ "credits", "http://www.mozilla.org/credits/", PR_TRUE },
{ "mozilla", "chrome://global/content/mozilla.html", PR_TRUE },
{ "plugins", "chrome://global/content/plugins.html", PR_TRUE },
{ "config", "chrome://global/content/config.xul", PR_FALSE }
};
static const int kRedirTotal = 4; // sizeof(kRedirMap)/sizeof(*kRedirMap)
@ -71,18 +84,15 @@ nsAboutRedirector::NewChannel(nsIURI *aURI, nsIChannel **result)
if (NS_FAILED(rv))
return rv;
static const char kChromePrefix[] = "chrome:";
for (int i = 0; i< kRedirTotal; i++)
{
if (!PL_strcasecmp(path.get(), kRedirMap[i][0]))
if (!PL_strcasecmp(path.get(), kRedirMap[i].id))
{
nsCOMPtr<nsIChannel> tempChannel;
rv = ioService->NewChannel(nsDependentCString(kRedirMap[i][1]),
rv = ioService->NewChannel(nsDependentCString(kRedirMap[i].url),
nsnull, nsnull, getter_AddRefs(tempChannel));
//-- If we're redirecting to a chrome URL, change the owner of the channel
// to keep the page from getting unnecessary privileges.
if (NS_SUCCEEDED(rv) && result &&
!PL_strncasecmp(kRedirMap[i][1], kChromePrefix, sizeof(kChromePrefix)-1))
// Keep the page from getting unnecessary privileges unless it needs them
if (NS_SUCCEEDED(rv) && result && kRedirMap[i].dropChromePrivs)
{
nsCOMPtr<nsIScriptSecurityManager> securityManager =
do_GetService(NS_SCRIPTSECURITYMANAGER_CONTRACTID, &rv);