Backed out changeset abf6af5e36d6 (bug 1537725) for bustages on libdav1d/moz.build. CLOSED TREE

This commit is contained in:
Csoregi Natalia 2019-03-26 11:32:42 +02:00
parent 9aff2faa39
commit 819dd52416
3 changed files with 16 additions and 29 deletions

View File

@ -25,17 +25,16 @@ CFLAGS += [
'-I%s/dist/include/dav1d/' % TOPOBJDIR,
]
stack_alignment = 0
# Default stack aligment is 16 bytes.
stack_alignment = 16
# Attaching config.asm file
if CONFIG['CPU_ARCH'] == 'x86':
# Default stack alignment can be 4 bytes.
if CONFIG['OS_TARGET'] == 'WINNT':
stack_alignment = 4
ASFLAGS += ['-I%s/media/libdav1d/asm/x86_32/win/' % TOPSRCDIR]
else:
ASFLAGS += ['-I%s/media/libdav1d/asm/x86_32/' % TOPSRCDIR]
stack_alignment = 16
# Change stack alignment to 16 bytes.
# Default stack aligment can be 4 bytes, change it to 16 bytes.
if CONFIG['CC_TYPE'] == 'clang':
CFLAGS += ['-mstack-alignment=16']
elif CONFIG['CC_TYPE'] == 'gcc':
@ -43,8 +42,6 @@ if CONFIG['CPU_ARCH'] == 'x86':
if CONFIG['CPU_ARCH'] == 'x86_64':
# Default stack aligment is 16 bytes.
stack_alignment = 16
if CONFIG['OS_TARGET'] == 'Darwin':
ASFLAGS += ['-I%s/media/libdav1d/asm/x86_64/osx/' % TOPSRCDIR]
elif CONFIG['OS_TARGET'] == 'WINNT':
@ -65,8 +62,6 @@ if CONFIG['CPU_ARCH'] == 'x86_64':
CFLAGS += ['-mpreferred-stack-boundary=5']
# Set the macro here instead of config.h
if stack_alignment == 0:
error('Stack alignment cannot be zero.')
DEFINES['STACK_ALIGNMENT'] = stack_alignment
if CONFIG['CPU_ARCH'] in ('x86', 'x86_64'):

View File

@ -9,5 +9,5 @@
%define PREFIX 1
%define STACK_ALIGNMENT 4
%define STACK_ALIGNMENT 16

View File

@ -32,17 +32,9 @@ DEFINES['DAV1D_API'] = ''
if CONFIG['MOZ_DAV1D_ASM']:
DIRS += ['asm']
# Store the stack alignment that will be used.
stack_alignment = 0
# Default stack alignment can be 4 bytes on x86.
if CONFIG['CPU_ARCH'] == 'x86':
if CONFIG['OS_TARGET'] == 'WINNT':
# Allow the default to avoid crashes
stack_alignment = 4
else:
# Update stack alignment to 16 bytes.
stack_alignment = 16
if CONFIG['CC_TYPE'] == 'clang':
CFLAGS += ['-mstack-alignment=16']
for ep in entrypoint_source_files:
@ -52,6 +44,8 @@ if CONFIG['MOZ_DAV1D_ASM']:
for ep in entrypoint_source_files:
SOURCES[ep].flags += ['-mincoming-stack-boundary=2']
# Expect stack alignment of 16 bytes.
stack_alignment = 16
# The default stack alignment in x86_64 is 16 bytes. On all Linux flavors the
# default is used due to crashes with 32 bytes stack alignment.
@ -68,8 +62,6 @@ if CONFIG['MOZ_DAV1D_ASM']:
SOURCES[ep].flags += ['-mincoming-stack-boundary=4']
# Set the macro here instead of config.h
if stack_alignment == 0:
error('Stack alignment cannot be zero.')
DEFINES['STACK_ALIGNMENT'] = stack_alignment
if CONFIG['OS_TARGET'] == 'Linux':