Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-15 06:15:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

XXX removal: don't destroy the stream on failure (a future ActorDestroy callback will take care of that), and other shutdown- and crash-related XXX removal which are handled by bug 529005

Browse Source
This commit is contained in:
Benjamin Smedberg 2009-11-25 15:34:49 -05:00
parent 9b8b8bbfe2
commit 822c6cd02f
3 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dom/plugins/BrowserStreamParent.cpp
View File

@ -50,11 +50,9 @@ BrowserStreamParent::WriteReady()
_MOZ_LOG(__FUNCTION__);
int32_t result;
if (!CallNPP_WriteReady(mStream->end, &result)) {
mNPP->mNPNIface->destroystream(mNPP->mNPP, mStream, NPRES_NETWORK_ERR);
// XXX is this right?
if (!CallNPP_WriteReady(mStream->end, &result))
return -1;
}
return result;
}

2
dom/plugins/PPluginModule.ipdl
View File

@ -69,8 +69,6 @@ child:
returns (NPError rv);
parent:
// XXX does NPN_UserAgent need to be RPC? certainly hope not, but to
// XXX be safe ...
rpc NPN_UserAgent()
returns (nsCString userAgent);

1
dom/plugins/PluginProcessParent.cpp
View File

@ -57,7 +57,6 @@ PluginProcessParent::PluginProcessParent(const std::string& aPluginFilePath) :
GeckoChildProcessHost(GeckoProcessType_Plugin),
mPluginFilePath(aPluginFilePath)
{
// XXXbent Need to catch crashing plugins by watching the process event!
}
PluginProcessParent::~PluginProcessParent()