Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-28 13:21:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 418766: Use width, not height, as a quick proxy for whether a line is empty. r+sr=roc, a=beltzner

Browse Source
This commit is contained in:
dholbert@cs.stanford.edu 2008-02-29 13:45:43 -08:00
parent 1586452eca
commit 828e13b8da
5 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
layout/generic/nsBlockFrame.cpp
View File

@ -1923,7 +1923,7 @@ nsBlockFrame::ReflowDirtyLines(nsBlockReflowState& aState)
// to the result of nextLine->ShouldApplyTopMargin.
if (line.next() != end_lines()) {
PRBool maybeWasEmpty = oldY == line.next()->mBounds.y;
PRBool isEmpty = line->mBounds.height == 0 && line->CachedIsEmpty();
PRBool isEmpty = line->mBounds.width == 0 && line->CachedIsEmpty();
if (maybeReflowingForFirstTime /*1*/ ||
(isEmpty || maybeWasEmpty) /*2/3/4*/) {
line.next()->MarkPreviousMarginDirty();

5
layout/reftests/bugs/418766-1-ref.html Normal file
View File

@ -0,0 +1,5 @@
<html>
<body>
b
</body>
</html>

16
layout/reftests/bugs/418766-1a.html Normal file
View File

@ -0,0 +1,16 @@
<html class="reftest-wait">
<head>
<script>
function boom()
{
var n = document.getElementById("editMe");
n.removeChild(n.firstChild);
document.documentElement.className = "";
}
</script>
</head>
<body onload="boom();">
<span id="editMe" style="margin-bottom: 1px;">a</span>
<div>b</div>
</body>
</html>

6
layout/reftests/bugs/418766-1b.html Normal file
View File

@ -0,0 +1,6 @@
<html>
<body>
<span id="editMe" style="margin-bottom: 1px;"></span>
<div>b</div>
</body>
</html>

2
layout/reftests/bugs/reftest.list
View File

@ -738,6 +738,8 @@ random == 403134-1.html 403134-1-ref.html # bug 405377
== 416106-1.xhtml 416106-1-ref.xhtml
== 416752-1.html 416752-1-ref.html
== 417676.html 417676-ref.html
== 418766-1a.html 418766-1-ref.html
== 418766-1b.html 418766-1-ref.html
== 419060.html 419060-ref.html
== 419531-1.html 419531-1-ref.html
== 420069-1.html 420069-1-ref.html