Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-11 01:57:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1318012 - SandboxBrokerCommon::SendWithFd sends uninitialised stack-allocated data out of process. r=jld@mozilla.com.

Browse Source
This commit is contained in:
Julian Seward 2016-11-21 07:33:19 +01:00
parent 6359310306
commit 8358f9ad56
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
security/sandbox/linux/broker/SandboxBrokerCommon.cpp
View File

@ -12,6 +12,7 @@
#include <sys/socket.h>
#include <sys/types.h>
#include <unistd.h>
#include <string.h>
#ifndef MSG_CMSG_CLOEXEC
#ifdef XP_LINUX
@ -99,6 +100,7 @@ SandboxBrokerCommon::SendWithFd(int aFd, const iovec* aIO, size_t aNumIO,
msg.msg_iovlen = aNumIO;
char cmsg_buf[CMSG_SPACE(sizeof(int))];
memset(cmsg_buf, 0, sizeof(cmsg_buf));
if (aPassedFd != -1) {
msg.msg_control = cmsg_buf;
msg.msg_controllen = sizeof(cmsg_buf);