Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-28 07:13:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1854625 - Temporarily disable some Tier 2 a11y_checks for Firefox View. r=fxview-reviewers,kcochrane

Browse Source 
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Firefox View-specific meta bug 1854626
- Explore capturing click events for a11y_checks: bug 1692110

Differential Revision: https://phabricator.services.mozilla.com/D188990
This commit is contained in:
Anna Yeddi 2023-10-06 18:11:39 +00:00
parent 7c01d8cbda
commit 83a1d27929
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
browser/components/firefoxview/tests/browser/browser.toml
View File

@ -15,6 +15,7 @@ skip-if = ["true"] # Bug 1783684
["browser_entrypoint_management.js"]
["browser_feature_callout.js"]
fail-if = ["a11y_checks"] # Bug 1854625 clicked brand-logo(s) may not be focusable
["browser_feature_callout_position.js"]
skip-if = ["os == 'linux'"] # Bug 1784343
@ -37,10 +38,12 @@ skip-if = ["os == 'linux'"] # Bug 1784343
skip-if = ["true"] # Bug 1851453
["browser_recently_closed_tabs.js"]
fail-if = ["a11y_checks"] # Bug 1854625 clicked a.closed-tab-li-title may not be focusable
["browser_recently_closed_tabs_keyboard.js"]
["browser_recently_closed_tabs_windows.js"]
fail-if = ["a11y_checks"] # Bug 1854625 clicked a.closed-tab-li-title may not be focusable
["browser_reload_firefoxview.js"]

6
browser/components/firefoxview/tests/browser/firefoxview-next/browser.toml
View File

@ -4,16 +4,22 @@ support-files = [ "../head.js"]
["browser_firefoxview_next.js"]
["browser_firefoxview_next_general_telemetry.js"]
fail-if = ["a11y_checks"] # Bug 1854625 clicked button and fxview-tab-row-secondary-button may not be focusable
["browser_history_firefoxview_next.js"]
fail-if = ["a11y_checks"] # Bug 1854625 clicked button may not be focusable
["browser_opentabs_firefoxview_next.js"]
fail-if = ["a11y_checks"] # Bug 1854625 clicked button, fxview-tab-row-secondary-button, panel-item may not be focusable
["browser_opentabs_recency_next.js"]
skip-if = ["os == 'mac' && verify"] # macos times out, see bug 1857293
["browser_recentlyclosed_firefoxview_next.js"]
fail-if = ["a11y_checks"] # Bug 1854625 clicked button, button.fxview-tab-row-secondary-button, and a.fxview-tab-row-main may not be focusable
["browser_syncedtabs_errors_firefoxview_next.js"]
fail-if = ["a11y_checks"] # Bug 1854625 clicked button may not be focusable
["browser_syncedtabs_firefoxview_next.js"]
fail-if = ["a11y_checks"] # Bug 1854625 clicked button may not be focusable