Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 06:11:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 429049: yahoo rss newsfeed (de.news.yahoo.com) is not previewed properly, patch by Will Guaraldi <will.guaraldi@pculture.org>, r+a=mconnor

Browse Source
This commit is contained in:
gavin@gavinsharp.com 2008-04-25 09:51:14 -07:00
parent 4c49692119
commit 83e30fc95b
2 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
toolkit/components/feeds/src/FeedProcessor.js
View File

@ -521,7 +521,9 @@ Entry.prototype = {
__enclosure_map: null,
_addToEnclosures: function Entry_addToEnclosures(new_enc) {
if (!bagHasKey(new_enc, "url"))
// items we add to the enclosures array get displayed in the FeedWriter and
// they must have non-empty urls.
if (!bagHasKey(new_enc, "url") || new_enc.getPropertyAsAString("url") == "")
return;
if (this.__enclosure_map == null)

32
toolkit/components/feeds/test/xml/rss2/mrss_content_429049.xml Normal file
View File

@ -0,0 +1,32 @@
<?xml version="1.0" encoding="iso-8859-1"?>
<!--
Description: this tests bug 429049. the item with a valid url is added to the enclosures array and the item with an empty url does not.
Expect: var encs = feed.items.queryElementAt(0, Components.interfaces.nsIFeedEntry).enclosures; encs.QueryInterface(Components.interfaces.nsIArray); (encs.length == 1);
-->
<rss xmlns:media="http://search.yahoo.com/mrss" version="2.0" >
<channel>
<item>
<media:content fileSize="24986239" type="audio/mpeg" url="http://dallas.example.com/joebob_050689.mp3" />
<author>jbb@dallas.example.com (Joe Bob Briggs)</author>
<comments>http://example.org</comments>
<title>test</title>
<category domain="foo">bar</category>
<description>no description</description>
</item>
<item>
<media:content url="" height="" width=""></media:content>
<author>jbb@dallas.example.com (Joe Bob Briggs)</author>
<comments>http://example.org</comments>
<title>test empty</title>
<category domain="foo">bar</category>
<description>no description</description>
</item>
</channel>
</rss>