Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 03:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1771822 - Do not explicitly set dom.visualviewport.enabled in tests. r=tnikkel

Browse Source 
This pref is now enabled by default on all platforms.

Depends on D147810

Differential Revision: https://phabricator.services.mozilla.com/D147811
This commit is contained in:
Botond Ballo 2022-06-02 22:57:56 +00:00
parent 18351c43de
commit 84fc68c001
16 changed files with 26 additions and 67 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
browser/components/sessionstore/test/browser_scrollPositions.js
View File

@ -57,9 +57,6 @@ function getScrollPosition(bc) {
* for an average page without any frames.
*/
async function test_scroll(aURL) {
// Needed for setScrollPosition()
await pushPrefs(["dom.visualviewport.enabled", true]);
let tab = BrowserTestUtils.addTab(gBrowser, aURL);
let browser = tab.linkedBrowser;
await promiseBrowserLoaded(browser);
@ -110,9 +107,6 @@ async function test_scroll(aURL) {
* for multiple frames of pages with framesets.
*/
async function test_scroll_nested() {
// Needed for setScrollPosition()
await pushPrefs(["dom.visualviewport.enabled", true]);
let tab = BrowserTestUtils.addTab(gBrowser, URL_FRAMESET);
let browser = tab.linkedBrowser;
await promiseBrowserLoaded(browser);
@ -185,11 +179,7 @@ async function test_scroll_nested() {
* are preserved as well (bug 1265818).
*/
async function test_scroll_background_tabs(aURL) {
await pushPrefs(
["browser.sessionstore.restore_on_demand", true],
// Needed for setScrollPosition()
["dom.visualviewport.enabled", true]
);
await pushPrefs(["browser.sessionstore.restore_on_demand", true]);
let newWin = await BrowserTestUtils.openNewBrowserWindow();
let tab = BrowserTestUtils.addTab(newWin.gBrowser, aURL);

6
browser/components/sessionstore/test/browser_scrollPositionsReaderMode.js
View File

@ -19,11 +19,7 @@ requestLongerTimeout(2);
* tabs in a restored window (bug 1153393).
*/
add_task(async function test_scroll_background_about_reader_tabs() {
await pushPrefs(
["browser.sessionstore.restore_on_demand", true],
// Needed for setScrollPosition()
["dom.visualviewport.enabled", true]
);
await pushPrefs(["browser.sessionstore.restore_on_demand", true]);
let newWin = await BrowserTestUtils.openNewBrowserWindow();
let tab = BrowserTestUtils.addTab(newWin.gBrowser, READER_MODE_URL);

4
dom/base/test/test_domwindowutils.html
View File

@ -93,9 +93,7 @@ function test_getUnanimatedComputedStyle() {
}
function test_setDynamicToolbarMaxHeight() {
SpecialPowers.pushPrefEnv({
set: [["dom.visualviewport.enabled", true]]
}).then(() => window.open("file_domwindowutils_dynamic_toolbar.html"));
window.open("file_domwindowutils_dynamic_toolbar.html");
}
var tests = [

1
dom/base/test/test_viewport_metrics_on_landscape_content.html
View File

@ -12,7 +12,6 @@ SpecialPowers.pushPrefEnv({
"set": [
["apz.allow_zooming", true],
["dom.meta-viewport.enabled", true],
["dom.visualviewport.enabled", true],
]
}, () => {
// We need to open a new window to avoid running tests in an iframe since

20
gfx/layers/apz/test/mochitest/test_group_double_tap_zoom-2.html
View File

@ -17,14 +17,8 @@ var doubletap_prefs = [
["apz.mac.enable_double_tap_zoom_touchpad_gesture", true],
];
var visualviewport_and_doubletap_prefs = [
var longeranimation_doubletap_prefs = [
...doubletap_prefs,
["dom.visualviewport.enabled", true],
];
var longeranimation_visualviewport_and_doubletap_prefs = [
...doubletap_prefs,
["dom.visualviewport.enabled", true],
["apz.zoom_animation_duration_ms", 1000],
];
@ -44,7 +38,7 @@ var meta_viewport_and_doubletap_prefs = [
];
var subtests = [
{"file": "helper_doubletap_zoom_smooth.html", "prefs": longeranimation_visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_smooth.html", "prefs": longeranimation_doubletap_prefs},
{"file": "helper_doubletap_zoom_fixedpos_overflow.html", "prefs": logging_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_hscrollable.html", "prefs": disable_default_zoomin_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_scrolled_overflowhidden.html", "prefs": doubletap_prefs},
@ -53,8 +47,8 @@ var subtests = [
{"file": "helper_doubletap_zoom_gencon.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_hscrollable2.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_nothing.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_noscroll.html", "prefs": visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_square.html", "prefs": visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_noscroll.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_square.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_oopif.html", "prefs": doubletap_prefs},
{"file": "helper_disallow_doubletap_zoom_inside_oopif.html", "prefs": meta_viewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_nothing_listener.html", "prefs": doubletap_prefs},
@ -62,7 +56,7 @@ var subtests = [
if (getPlatform() == "mac") {
subtests.push(
{"file": "helper_doubletap_zoom_smooth.html?touchpad", "prefs": longeranimation_visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_smooth.html?touchpad", "prefs": longeranimation_doubletap_prefs},
{"file": "helper_doubletap_zoom_fixedpos_overflow.html?touchpad", "prefs": logging_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_hscrollable.html?touchpad", "prefs": disable_default_zoomin_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_scrolled_overflowhidden.html?touchpad", "prefs": doubletap_prefs},
@ -71,8 +65,8 @@ if (getPlatform() == "mac") {
{"file": "helper_doubletap_zoom_gencon.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_hscrollable2.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_nothing.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_noscroll.html?touchpad", "prefs": visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_square.html?touchpad", "prefs": visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_noscroll.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_square.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_oopif.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_disallow_doubletap_zoom_inside_oopif.html?touchpad", "prefs": meta_viewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_nothing_listener.html?touchpad", "prefs": doubletap_prefs},

17
gfx/layers/apz/test/mochitest/test_group_double_tap_zoom.html
View File

@ -17,11 +17,6 @@ var doubletap_prefs = [
["apz.mac.enable_double_tap_zoom_touchpad_gesture", true],
];
var visualviewport_and_doubletap_prefs = [
...doubletap_prefs,
["dom.visualviewport.enabled", true],
];
var logging_and_doubletap_prefs = [
...doubletap_prefs,
["apz.test.logging_enabled", true],
@ -31,11 +26,11 @@ var subtests = [
{"file": "helper_doubletap_zoom.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_img.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_textarea.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_horizontal_center.html", "prefs": visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_bug1702464.html", "prefs": visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_horizontal_center.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_bug1702464.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_large_overflow.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_fixedpos.html", "prefs": logging_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_tallwide.html", "prefs": visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_tallwide.html", "prefs": doubletap_prefs},
];
if (getPlatform() == "mac") {
@ -43,15 +38,15 @@ if (getPlatform() == "mac") {
{"file": "helper_doubletap_zoom.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_img.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_textarea.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_horizontal_center.html?touchpad", "prefs": visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_horizontal_center.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_small.html", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_small.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_bug1702464.html?touchpad", "prefs": visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_bug1702464.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_htmlelement.html", "prefs": doubletap_prefs}, // scrollbars don't receive events or take space on android
{"file": "helper_doubletap_zoom_htmlelement.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_large_overflow.html?touchpad", "prefs": doubletap_prefs},
{"file": "helper_doubletap_zoom_fixedpos.html?touchpad", "prefs": logging_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_tallwide.html?touchpad", "prefs": visualviewport_and_doubletap_prefs},
{"file": "helper_doubletap_zoom_tallwide.html?touchpad", "prefs": doubletap_prefs},
);
}

1
gfx/layers/apz/test/mochitest/test_group_fullscreen.html
View File

@ -14,7 +14,6 @@
prefs: [
["apz.test.logging_enabled", true],
["full-screen-api.allow-trusted-requests-only", false],
["dom.visualviewport.enabled", true],
],
},
];

2
gfx/layers/apz/test/mochitest/test_group_minimum_scale_size.html
View File

@ -27,8 +27,6 @@ const prefs = [
// Similarly, explicitly enable support for meta viewport tags (which the
// test cases use) so they're processed even on desktop.
["dom.meta-viewport.enabled", true],
// We use the Visual Viewport API to tell the visual viewport offset.
["dom.visualviewport.enabled", true],
];
const subtests = [

8
gfx/layers/apz/test/mochitest/test_group_pointerevents.html
View File

@ -20,12 +20,12 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1285070
{"file": "helper_bug1299195.html", "prefs": [["dom.meta-viewport.enabled", isMac]]},
{"file": "helper_bug1414336.html", "prefs": [["apz.test.fails_with_native_injection", isWindows]]},
{"file": "helper_bug1502010_unconsumed_pan.html"},
{"file": "helper_bug1544966_zoom_on_touch_action_none.html", "prefs": [...touch_action_prefs]},
{"file": "helper_bug1648491_no_pointercancel_with_dtc.html", "prefs": [...touch_action_prefs]},
{"file": "helper_bug1544966_zoom_on_touch_action_none.html", "prefs": touch_action_prefs},
{"file": "helper_bug1648491_no_pointercancel_with_dtc.html", "prefs": touch_action_prefs},
{"file": "helper_bug1663731_no_pointercancel_on_second_touchstart.html",
"prefs": [["dom.visualviewport.enabled", true], ...touch_action_prefs]},
"prefs": touch_action_prefs},
{"file": "helper_bug1682170_pointercancel_on_touchaction_pinchzoom.html",
"prefs": [["dom.visualviewport.enabled", true], ...touch_action_prefs]},
"prefs": touch_action_prefs},
];
if (isApzEnabled()) {

7
gfx/layers/apz/test/mochitest/test_group_touchevents-4.html
View File

@ -17,17 +17,16 @@ var subtests = [
// Resetting isFirstPaint shouldn't clobber the visual viewport
{"file": "helper_bug1509575.html", "prefs": [
["apz.allow_zooming", true],
["dom.visualviewport.enabled", true],
...getPrefs("TOUCH_EVENTS:PAN")
]},
// Exercise one of the main-thread touch-action determination codepaths.
{"file": "helper_bug1506497_touch_action_fixed_on_fixed.html", "prefs": touch_action_prefs},
{"file": "helper_bug1637113_main_thread_hit_test.html",
"prefs": [["apz.allow_zooming", true], ["dom.visualviewport.enabled", true]]},
"prefs": [["apz.allow_zooming", true]]},
{"file": "helper_bug1638458_contextmenu.html",
"prefs": [["apz.allow_zooming", true], ["dom.visualviewport.enabled", true]]},
"prefs": [["apz.allow_zooming", true]]},
{"file": "helper_bug1638441_fixed_pos_hit_test.html",
"prefs": [["apz.allow_zooming", true], ["dom.visualviewport.enabled", true]]},
"prefs": [["apz.allow_zooming", true]]},
{"file": "helper_bug1637135_narrow_viewport.html", "prefs": [["apz.allow_zooming", true],
["dom.meta-viewport.enabled", true]]},
{"file": "helper_bug1714934_mouseevent_buttons.html"},

5
gfx/layers/apz/test/mochitest/test_group_touchevents.html
View File

@ -13,10 +13,7 @@ var basic_pan_prefs = getPrefs("TOUCH_EVENTS:PAN");
var subtests = [
// Simple tests to exercise basic panning behaviour
{"file": "helper_basic_pan.html", "prefs": [
["dom.visualviewport.enabled", true],
...basic_pan_prefs
]},
{"file": "helper_basic_pan.html", "prefs": basic_pan_prefs},
{"file": "helper_div_pan.html", "prefs": basic_pan_prefs},
{"file": "helper_iframe_pan.html", "prefs": basic_pan_prefs},

2
gfx/layers/apz/test/mochitest/test_group_zoom-2.html
View File

@ -37,8 +37,6 @@ var prefs = [
// Disable touch resampling so that touch events are processed without delay
// and we don't zoom more than expected due to overprediction.
["android.touch_resampling.enabled", false],
// Tests depend on window.visualViewport
["dom.visualviewport.enabled", true],
];
var instant_repaint_prefs = [

2
gfx/layers/apz/test/mochitest/test_group_zoom.html
View File

@ -32,8 +32,6 @@ var prefs = [
// Disable touch resampling so that touch events are processed without delay
// and we don't zoom more than expected due to overprediction.
["android.touch_resampling.enabled", false],
// Tests depend on window.visualViewport
["dom.visualviewport.enabled", true],
];
// Increase the tap timeouts so the one-touch-pinch gesture is still detected

1
layout/base/tests/browser_visual_viewport_iframe.js
View File

@ -13,7 +13,6 @@ add_task(async () => {
set: [
["apz.allow_zooming", true],
["dom.meta-viewport.enabled", true],
["dom.visualviewport.enabled", true],
],
});

3
testing/web-platform/meta/css/css-device-adapt/__dir__.ini
View File

@ -1,3 +1,2 @@
implementation-status: not-implementing
prefs: [dom.visualviewport.enabled:true,
apz.allow_zooming:true]
prefs: [apz.allow_zooming:true]

2
testing/web-platform/meta/visual-viewport/__dir__.ini
View File

@ -1 +1 @@
prefs: [dom.visualviewport.enabled:true, apz.allow_zooming:true]
prefs: [apz.allow_zooming:true]