From 850a52b360f3882a4bad862ce962040170e47b4c Mon Sep 17 00:00:00 2001 From: Matt Woodrow Date: Fri, 14 Dec 2018 19:31:59 +0000 Subject: [PATCH] Bug 1500864 - Don't record a display list mutation based on the partial build rect, rely on comparisons during merging. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D14303 --HG-- extra : moz-landing-system : lando --- layout/painting/RetainedDisplayListBuilder.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/layout/painting/RetainedDisplayListBuilder.cpp b/layout/painting/RetainedDisplayListBuilder.cpp index c6db8985bee9..05f861a6887a 100644 --- a/layout/painting/RetainedDisplayListBuilder.cpp +++ b/layout/painting/RetainedDisplayListBuilder.cpp @@ -1263,11 +1263,6 @@ auto RetainedDisplayListBuilder::AttemptPartialUpdate( modifiedDirty, mBuilder.RootReferenceFrame()->GetVisualOverflowRectRelativeToSelf()); - PartialUpdateResult result = PartialUpdateResult::NoChange; - if (!modifiedDirty.IsEmpty() || !framesWithProps.IsEmpty()) { - result = PartialUpdateResult::Updated; - } - mBuilder.SetDirtyRect(modifiedDirty); mBuilder.SetPartialUpdate(true); @@ -1309,6 +1304,7 @@ auto RetainedDisplayListBuilder::AttemptPartialUpdate( // we call RestoreState on nsDisplayWrapList it resets the clip to the base // clip, and we need the UpdateBounds call (within MergeDisplayLists) to // move it to the correct inner clip. + PartialUpdateResult result = PartialUpdateResult::NoChange; Maybe dummy; if (MergeDisplayLists(&modifiedDL, &mList, &mList, dummy)) { result = PartialUpdateResult::Updated;