Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-22 10:27:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1453127 - Do not use iterators in MediaStreamTrack when removing listeners. r=pehrsons

Browse Source 
--HG--
extra : rebase_source : 41c5d93b54c6dc062daa05a2644d4a194400dd1e
extra : amend_source : c53c4f75e4b813104122d22da29f97919f9d62d3
This commit is contained in:
Bryce Van Dyk 2018-04-18 15:30:57 -04:00
parent e6081ca579
commit 855803da5c
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dom/media/MediaStreamTrack.cpp
View File

@ -166,11 +166,15 @@ MediaStreamTrack::Destroy()
mPrincipalHandleListener->Forget();
mPrincipalHandleListener = nullptr;
}
for (auto l : mTrackListeners) {
RemoveListener(l);
// Remove all listeners -- avoid iterating over the list we're removing from
const nsTArray<RefPtr<MediaStreamTrackListener>> trackListeners(mTrackListeners);
for (auto listener : trackListeners) {
RemoveListener(listener);
}
for (auto l : mDirectTrackListeners) {
RemoveDirectListener(l);
// Do the same as above for direct listeners
const nsTArray<RefPtr<DirectMediaStreamTrackListener>> directTrackListeners(mDirectTrackListeners);
for (auto listener : directTrackListeners) {
RemoveDirectListener(listener);
}
}